Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid writing into ~/.stack directory during build for git-annex #21452

Merged

Conversation

smoors
Copy link
Contributor

@smoors smoors commented Sep 19, 2024

(created using eb --new-pr)

@smoors smoors changed the title avoid writing to ~/.stack file for git-annex avoid writing to ~/.stack directory for git-annex Sep 19, 2024
@smoors smoors changed the title avoid writing to ~/.stack directory for git-annex avoid writing into ~/.stack directory during build for git-annex Sep 19, 2024
@smoors smoors added the bug fix label Sep 19, 2024
@smoors
Copy link
Contributor Author

smoors commented Sep 20, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=21452 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21452 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14303

Test results coming soon (I hope)...

- notification for comment with ID 2362960790 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/e293ec3cbc700e9107596a1dfa1a0bdf for a full test report.

@smoors
Copy link
Contributor Author

smoors commented Sep 20, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21452 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21452 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4902

Test results coming soon (I hope)...

- notification for comment with ID 2363202523 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/be0d0cbad86d420f790aca4c9b5b794b for a full test report.

@smoors smoors added this to the release after 4.9.3 milestone Sep 20, 2024
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Contributor

lexming commented Sep 20, 2024

Merging, thanks @smoors !

@lexming lexming merged commit 3c2035c into easybuilders:develop Sep 20, 2024
9 checks passed
@boegel boegel changed the title avoid writing into ~/.stack directory during build for git-annex avoid writing into ~/.stack directory during build for git-annex Sep 21, 2024
@boegel boegel modified the milestones: release after 4.9.4, 4.9.4 Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants