-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{bundle}[dummy] GCC-4.9.3-2.25: bundle of GCCcore 4.9.3 and binutils 2.25 #2214
Conversation
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5252/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
5232871
to
8c6037f
Compare
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5253/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5254/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
Test report by @boegel |
Test report by @boegel |
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5255/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
Looks fine, but preferably (but not possible currently), the |
Hiding a toolchain isn't possible yet, but we can add a The problem is, it will always be printed, I'm not sure we can actually detect a 'manual' load... |
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5265/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
@wpoely86: also, hiding modules is considered a site-specific choice, it shouldn't be hardcoded somewhere... Lmod will hopefully soon allow to make modules invisible (simply not show them in |
Well, we create a module that never should be loaded directly by the user. That makes hiding it no longer a site specific choice. |
@wpoely86: well, shouldn't, but they will get a GCC that works, they're just going to rely on the OS-provided binutils in that case. The current situation is worse, where people should load GNU, rather than GCC. Anyway, support for hiding toolchains will be added at some point, and I'm willing to have the discussion of hiding |
I don't like that you intend to use GCC as a base for iccifort, this means I can't put iccifort and GCC in the 'compiler' family since I need them both loaded at once. Is it not ok to explicitly list GCCcore and bintuils for those cases? |
@ocaisa: you're right, I shouldn't be using Besides that, do you agree that this |
I'm happy with this. The setup is completely flexible so works in all scenarios. A bundle is fine for the use case here and the setup in the framework still gives me the freedom to build a different GCC version and use that instead...that's my target use case, GCCcore 4.9.3 for all my compilers (Intel, PGI, GCC) with the GCC version being 5.X (configured to use the old C++ ABI be default for compatbility with software installed using GCCcore). |
Test report by @boegel |
Test report by @boegel |
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5297/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
As agreed with @ocaisa (who created #2108) and @geimer, I'm merging this one rather than #2108, for a number of reasons:
Thanks for the review @wpoely86, and @ocaisa and @geimer for the feedback! |
{bundle}[dummy] GCC-4.9.3-2.25: bundle of GCCcore 4.9.3 and binutils 2.25
requires
easybuilders/easybuild-framework#1451and easybuilders/easybuild-easyblocks#773This sort of replaces #2108, and deals with a coupe of problems there, in particular:
foss
toolchain; theGCC
is just a bundle ofGCCcore
andbinutils
binutils
from versionsuffix ofGCCcore
(since it's only a build dep there)-binutils-2.25
as versionsuffix forbinutils-2.25
; it looks stupid, and which binutils was used to build binutils with is most likely irrelevantAs opposed to #2108, these additional easyconfigs do not affect existing toolchain, in particular the
2015b
ones, which are close to 'end of life', and thus should not be fiddled with.The intention is to use the
GCC/4.9.3-2.25
bundle as a base for the2016a
toolchains (#2194 will be adjusted to use it, sinceintel/2015.08
a likely candidate forintel/2016a
).There's a
GCC/4.9.3-binutils-2.25
too, which is an actual GCC build rather than a bundle. This may be confusing right now, but since there's no GCC 4.9 or binutils update, that's the way it is.@ocaisa, @geimer, @wpoely86: thoughts?