Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style checks #2376

Closed
wants to merge 4 commits into from
Closed

Add style checks #2376

wants to merge 4 commits into from

Conversation

wpoely86
Copy link
Member

@boegel @rjeschmi
Based on pep8. The first test will fail as example. Will push fixes in a moment.

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5865/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@wpoely86
Copy link
Member Author

retest this please

@boegel
Copy link
Member

boegel commented Jan 27, 2016

@wpoely86: most of the code supporting the style checks should be added in framework, so we can also use it in --new-pr; here, you can import from easybuild.framework.easyconfig.style (or whatever)

@boegel boegel added this to the v2.7.0 milestone Jan 27, 2016
@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5866/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5867/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member

boegel commented Feb 17, 2016

@wpoely86: all PRs that include style checks merged, please sync with develop?

* develop: (227 commits)
  consistently use %(perlver)s
  disable optarch toolchain option to dance around internal compiler error
  additional style fixes in xtrans easyconfigs
  additional style fixes in TCC, Vampir, VampirServer and ViennaRNA easyconfigs
  Don't use %(perl)s and add Perl as a dep.
  additional style fixes in psmpi easyconfigs
  additional style fixes in Python easyconfigs
  additional style fixes in ParMETIS easyconfigs
  add comments in patch files
  {vis}[intel/2016a] PyFFmpeg 2.1beta + FFmpeg 0.10.16
  additional style fixes in OpenFOAM easyconfigs
  additional style fixes in Oger easyconfigs
  additional style fixes in nettle easyconfigs
  additional style fixes in ncurses easyconfigs
  additional style fixes in NCO easyconfigs
  additional style fixes in MultiNest easyconfigs
  additional style fixes in MCR easyconfigs
  Use of source name template
  Messing w/ the %s vs %%(perl)s style interpolation.
  Use Perl suffix and factor out 'kmer'
  ...
@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6274/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@boegel boegel modified the milestones: v2.8.0, v2.7.0 Mar 11, 2016
@boegel boegel modified the milestones: v2.8.0, v2.9.0 May 10, 2016
@boegel boegel modified the milestones: 3.0, v2.9.0 Sep 19, 2016
@boegel boegel modified the milestones: 3.0, 3.1 Nov 14, 2016
@boegel
Copy link
Member

boegel commented Nov 29, 2016

@wpoely86 replaced by #2506 ?

@wpoely86
Copy link
Member Author

Yes, see #2506

@wpoely86 wpoely86 closed this Nov 29, 2016
@wpoely86 wpoely86 deleted the pep8-checks branch February 10, 2017 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants