-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arpack-ng #451
arpack-ng #451
Conversation
MPI version works. |
Job well done! This may resolve partially or fully (see the tables where applicable): Thanks @wpoely86 ! |
…r than one for a Clang-based toolchain)
…tions in toolchain easyconfigs
fix remarks
add gzip easyconfig for gmpolf toolchain, clean up comments in gmpolf toolchain
add easyconfigs for gmpolf toolchain + example easyconfig for gzip with gmpolf
Conflicts: setup.py
Please check my pull request (#481). I have some additions in the patch file. |
@tloizou thanks for the additions to the patch file. The permanent fix is already upstream ( http://forge.scilab.org/index.php/p/arpack-ng/issues/1321/ ). It boils down to using an old version of libtool. I'm going to pull the upstream changes as a patch. That will give a large patch but will fix the issue permanently for everybody. btw, You can also issue a pull request to my branch instead of a PR to the easyconfig repo. In that way, we can merge both our changes in 1 PR to easyconfig. That should make the life of @boegel a bit easier 😉 |
The autotools have been updated to the latest versions. This should fix a problem with intel MPI not being recognized by the configure scripts.
There are now 3 patches: one to bring arpack-ng to the current git HEAD (this is needed for the autotools update patch), one to update autotools (and fix all MPI issues) and one to update pkg-config.in file
…ild-easyconfigs into arpack-ng * 'contrib_arpack_ng' of https://github.com/tloizou/easybuild-easyconfigs: (46 commits) Change in config file Making changes in arpack-ng Adding arpack-ng Adding arpack-ng fix typo update release notes for EasyBuild v1.8.2 port thread pool patch to PSI 4.0b4, and use it to fix 'hanging' tests add gzip easyconfig for gmpolf toolchain, clean up comments in gmpolf toolchain fix final remarks align gmpich2 and gmpolf toolchain versions, fix dependency specifications in toolchain easyconfigs rebase gmpich easyconfig for FFTW 3.3.3 on gmvapich easyconfig (rather than one for a Clang-based toolchain) bump version to 1.9.0.0dev add PR easybuilders#462 to release notes, fix typo fix easyconfig file names w.r.t version suffixes bump version to v1.8.1.0, update release notes correct version to v1.8.1.0 PSI: avoid duplicate patch remove respecifying default max_fail_ratio of 0.5 in NWChem easyconfig really fix typo in patch file fix typo in patch file ... Conflicts: easybuild/easyconfigs/a/arpack-ng/arpack-ng-3.1.3-configure-mpi.patch
I've updated things a bit. We now patch to the latest git HEAD so we can use the upstream patch for autotools. This should fix all issues with Intel MPI. I've split it up into three patches (see the commit messages). @tloizou I've pulled in your PR (#481), and changed some things. Can you check if everything still works for you? As a result, some unrelated commits have been added as @tloizou branch was branched off after my branch. I hope this is now problem for you @boegel ? |
Automatic reply from Jenkins: Can I test this? |
Jenkins: ok to test |
configopts = '--enable-mpi --with-pic --with-blas="$LIBBLAS" --with-lapack="$LIBLAPACK"' | ||
|
||
sanity_check_paths = { | ||
'files': ["lib/libarpack.a", "lib/libarpack.so", "lib/libparpack.a", "lib/libarpack.a"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lib/libarpack.a
is checked twice, once is good enough ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be libparpack.so
, fixed in latest commit.
@wpoely86: The list of patches for the MPI versions doesn't work (the
Also, I rather prefer the minimal patch that @tloizou was using, since it makes it a lot more clear what's going on exactly... What's the |
The reason the patch is so big, is that I updated autotools to their latest version. This fixes the MPI problem for everybody. I had to patch something to get MPI working, @tloizou needed something patched too, ... These patches are big but fix the problem for all cases. But maybe I should make a version of my own It's very strange that these patches fail for you. They apply cleanly here. Are you testing |
@wpoely86: The patch issue must be because of a difference in the version of the The problem seems to come from the patch itself: it effectively has two blocks for creating the |
Btw, |
|
oeps, it was a symlink and that was wrong. The patch first creates a symlink, then deletes, and fills in the file. The first two steps can be skipped. Do you fix it or should I do it? |
@wpoely86: Fixed in wpoely86#8 |
Can you retest the build with the adjusted patch on your end? |
build works on my end. |
Merging in, thanks @wpoely86! |
Currently only the non-mpi version. The MPI version gives errors.