Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arpack-ng #451

Merged
merged 26 commits into from
Nov 11, 2013
Merged

arpack-ng #451

merged 26 commits into from
Nov 11, 2013

Conversation

wpoely86
Copy link
Member

@wpoely86 wpoely86 commented Oct 4, 2013

Currently only the non-mpi version. The MPI version gives errors.

@wpoely86
Copy link
Member Author

wpoely86 commented Oct 4, 2013

MPI version works.

@fgeorgatos
Copy link
Contributor

Job well done!

This may resolve partially or fully (see the tables where applicable):
easybuilders/easybuild-easyblocks#85
easybuilders/easybuild-easyblocks#86
easybuilders/easybuild-easyblocks#97 # arpack-only oriented
easybuilders/easybuild-easyblocks#111

Thanks @wpoely86 !

@tloizou
Copy link
Contributor

tloizou commented Oct 24, 2013

Please check my pull request (#481). I have some additions in the patch file.

@wpoely86
Copy link
Member Author

@tloizou thanks for the additions to the patch file. The permanent fix is already upstream ( http://forge.scilab.org/index.php/p/arpack-ng/issues/1321/ ). It boils down to using an old version of libtool. I'm going to pull the upstream changes as a patch. That will give a large patch but will fix the issue permanently for everybody.

btw, You can also issue a pull request to my branch instead of a PR to the easyconfig repo. In that way, we can merge both our changes in 1 PR to easyconfig. That should make the life of @boegel a bit easier 😉

Thekla and others added 7 commits October 24, 2013 17:46
The autotools have been updated to the latest versions. This should fix
a problem with intel MPI not being recognized by the configure scripts.
There are now 3 patches: one to bring arpack-ng to the current git HEAD
(this is needed for the autotools update patch), one to update autotools
(and fix all MPI issues) and one to update pkg-config.in file
…ild-easyconfigs into arpack-ng

* 'contrib_arpack_ng' of https://github.com/tloizou/easybuild-easyconfigs: (46 commits)
  Change in config file
  Making changes in arpack-ng
  Adding arpack-ng
  Adding arpack-ng
  fix typo
  update release notes for EasyBuild v1.8.2
  port thread pool patch to PSI 4.0b4, and use it to fix 'hanging' tests
  add gzip easyconfig for gmpolf toolchain, clean up comments in gmpolf toolchain
  fix final remarks
  align gmpich2 and gmpolf toolchain versions, fix dependency specifications in toolchain easyconfigs
  rebase gmpich easyconfig for FFTW 3.3.3 on gmvapich easyconfig (rather than one for a Clang-based toolchain)
  bump version to 1.9.0.0dev
  add PR easybuilders#462 to release notes, fix typo
  fix easyconfig file names w.r.t version suffixes
  bump version to v1.8.1.0, update release notes
  correct version to v1.8.1.0
  PSI: avoid duplicate patch
  remove respecifying default max_fail_ratio of 0.5 in NWChem easyconfig
  really fix typo in patch file
  fix typo in patch file
  ...

Conflicts:
	easybuild/easyconfigs/a/arpack-ng/arpack-ng-3.1.3-configure-mpi.patch
@wpoely86
Copy link
Member Author

wpoely86 commented Nov 4, 2013

I've updated things a bit. We now patch to the latest git HEAD so we can use the upstream patch for autotools. This should fix all issues with Intel MPI. I've split it up into three patches (see the commit messages).

@tloizou I've pulled in your PR (#481), and changed some things. Can you check if everything still works for you?

As a result, some unrelated commits have been added as @tloizou branch was branched off after my branch. I hope this is now problem for you @boegel ?

@wpoely86 wpoely86 mentioned this pull request Nov 4, 2013
@hpcugentbot
Copy link
Contributor

Automatic reply from Jenkins: Can I test this?

@boegel
Copy link
Member

boegel commented Nov 11, 2013

Jenkins: ok to test

configopts = '--enable-mpi --with-pic --with-blas="$LIBBLAS" --with-lapack="$LIBLAPACK"'

sanity_check_paths = {
'files': ["lib/libarpack.a", "lib/libarpack.so", "lib/libparpack.a", "lib/libarpack.a"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib/libarpack.a is checked twice, once is good enough ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be libparpack.so, fixed in latest commit.

@boegel
Copy link
Member

boegel commented Nov 11, 2013

@wpoely86: The list of patches for the MPI versions doesn't work (the -mt build is OK), even without touching the order... I guess you including a full-blown patch for configure rather than a minimal one broke stuff.

== 2013-11-11 19:27:49,804 main.filetools ERROR EasyBuild crashed with an error
(at easybuild/tools/filetools.py:700 in parse_cmd_output):
cmd "patch -b -p1 -i <path>/arpack-ng-3.1.3-configure-mpi.patch" exited with exitcode 1 and output:
...
patching file m4/libtool.m4
patching file m4/ltoptions.m4
patching file missing
patching file compile
The next patch would create the file compile,
which already exists!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
1 out of 1 hunk ignored

Also, I rather prefer the minimal patch that @tloizou was using, since it makes it a lot more clear what's going on exactly...

What's the update-to-head patch about? Is that only bug fixes? Maybe that should be reflected by a version suffix like -patched or somesuch, since this build is not a clean 3.1.3?

@wpoely86
Copy link
Member Author

The reason the patch is so big, is that I updated autotools to their latest version. This fixes the MPI problem for everybody. I had to patch something to get MPI working, @tloizou needed something patched too, ... These patches are big but fix the problem for all cases. But maybe I should make a version of my own arpack-ng-20131111-ictce-5.5.0.eb or so.

It's very strange that these patches fail for you. They apply cleanly here. Are you testing arpack-ng-3.1.3-ictce-5.5.0.eb? It complains about the file compile existing already but If I look in the tarball, it isn't there?

@boegel
Copy link
Member

boegel commented Nov 11, 2013

@wpoely86: The patch issue must be because of a difference in the version of the patch command (I have version 2.6)...

The problem seems to come from the patch itself: it effectively has two blocks for creating the compile file. The first is at lines 383-390, the second at 3863-... The second block first deletes the existing file, which is where it goes wrong probably. Let me try and fix it (I love editing patch files :P).

@wpoely86
Copy link
Member Author

compile should be a symlink, so it should be easy.

Btw, patch 2.7.1 FTW 😉

@boegel
Copy link
Member

boegel commented Nov 11, 2013

compile should be a symlink? to what? the patch file doesn't suggest it's a symlink...

@wpoely86
Copy link
Member Author

oeps, it was a symlink and that was wrong. The patch first creates a symlink, then deletes, and fills in the file. The first two steps can be skipped. Do you fix it or should I do it?

@boegel
Copy link
Member

boegel commented Nov 11, 2013

@wpoely86: Fixed in wpoely86#8

@boegel
Copy link
Member

boegel commented Nov 11, 2013

Can you retest the build with the adjusted patch on your end?

@wpoely86
Copy link
Member Author

build works on my end.

@boegel
Copy link
Member

boegel commented Nov 11, 2013

Merging in, thanks @wpoely86!

boegel added a commit that referenced this pull request Nov 11, 2013
@boegel boegel merged commit 9623746 into easybuilders:develop Nov 11, 2013
@wpoely86 wpoely86 deleted the arpack-ng branch November 11, 2013 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants