Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{lang}[foss/2017a] Python v2.7.13 #4512

Merged

Conversation

henkela
Copy link
Contributor

@henkela henkela commented Apr 25, 2017

(created using eb --new-pr)

@boegelbot
Copy link
Collaborator

Travis test report: 8/8 runs failed - see https://travis-ci.org/hpcugent/easybuild-easyconfigs/builds/225712699

Only showing partial log for 1st failed test suite run 4394.1;
full log at https://travis-ci.org/hpcugent/easybuild-easyconfigs/jobs/225712700

...
FAIL: Check whether any conflicts occur in software dependency graphs.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/hpcugent/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 152, in test_conflicts
    "No conflicts detected")
AssertionError: No conflicts detected

----------------------------------------------------------------------
Ran 6907 tests in 287.260s

FAILED (failures=1)
ERROR: Not all tests were successful.

('libreadline', '6.3'),
('ncurses', '6.0'),
('SQLite', '3.13.0'),
('Tk', '8.6.5'), # this requires a full X11 stack
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henkela The easyconfig for this Tk version includes a dependency on zlib 1.2.8, which conflicts with the zlib used in this easyconfig file.

Besides that, any reason you are not porting the easyconfig for Python 2.7.13 we have with the intel/2017a toolchain to foss/2017a instead?

We took a slightly different approach there, by avoiding to include Tk as a dependency since that requires X11 (which is kind of silly as a dep for Python). That does mean the Tkinter part of Python is not available (see also #4225).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel I updated my local version of Tk to use zlib 1.2.11.
I missed the 2.7.13 version because I didn't check the develop branch earlier. Sorry for that.
For easyconfigs that need other updated easyconfigs, how should I pull-request them? All needed files in one pull request?

@boegel boegel added this to the 3.3.0 milestone Apr 26, 2017
@boegelbot
Copy link
Collaborator

Travis test report: 8/8 runs failed - see https://travis-ci.org/hpcugent/easybuild-easyconfigs/builds/226280310

Only showing partial log for 1st failed test suite run 4411.1;
full log at https://travis-ci.org/hpcugent/easybuild-easyconfigs/jobs/226280311

...
FAIL: Check whether any conflicts occur in software dependency graphs.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/hpcugent/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 152, in test_conflicts
    "No conflicts detected")
AssertionError: No conflicts detected

----------------------------------------------------------------------
Ran 6908 tests in 274.301s

FAILED (failures=1)
ERROR: Not all tests were successful.

@boegel
Copy link
Member

boegel commented Apr 27, 2017

@henkela You should drop the easyconfig for Python 2.7.12 if it's no longer relevant (see http://easybuild.readthedocs.io/en/latest/Integration_with_GitHub.html#deleting-easyconfig-files-or-patches), and update the PR title.

To answer your question w.r.t. dependencies: if the total amount of easyconfigs is reasonable (say, < 10), it's OK to pack them all in a single pull request, especially if they're trivial version/toolchain updates since those are easy to review for us via --review-pr (cfr. http://easybuild.readthedocs.io/en/latest/Integration_with_GitHub.html#reviewing-easyconfig-pull-requests-review-pr).

One thing you should do is clean up the contributed easyconfig file, by removing the auto-added comments like # Built with EasyBuild and the buildstats.

@boegel boegel changed the title {lang}[foss/2017a] Python v2.7.12 {lang}[foss/2017a] Python v2.7.13 May 8, 2017
@boegel
Copy link
Member

boegel commented May 8, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2507.golett.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/48cf2a3aaaffe950b61ef0f8966894f0 for a full test report.

@boegel
Copy link
Member

boegel commented May 8, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2109.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/e6cef0f009e5c52f1900489e515e1aa6 for a full test report.

@boegel
Copy link
Member

boegel commented May 8, 2017

lgtm

@boegel
Copy link
Member

boegel commented May 8, 2017

Going in, thanks @henkela!

@boegel boegel merged commit d2226c1 into easybuilders:develop May 8, 2017
@boegel boegel modified the milestones: 3.2.1, 3.3.0 May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants