-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{lang}[foss/2017a] Python v2.7.13 #4512
{lang}[foss/2017a] Python v2.7.13 #4512
Conversation
Travis test report: 8/8 runs failed - see https://travis-ci.org/hpcugent/easybuild-easyconfigs/builds/225712699 Only showing partial log for 1st failed test suite run 4394.1;
|
('libreadline', '6.3'), | ||
('ncurses', '6.0'), | ||
('SQLite', '3.13.0'), | ||
('Tk', '8.6.5'), # this requires a full X11 stack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@henkela The easyconfig for this Tk version includes a dependency on zlib 1.2.8, which conflicts with the zlib used in this easyconfig file.
Besides that, any reason you are not porting the easyconfig for Python 2.7.13 we have with the intel/2017a
toolchain to foss/2017a
instead?
We took a slightly different approach there, by avoiding to include Tk as a dependency since that requires X11 (which is kind of silly as a dep for Python). That does mean the Tkinter
part of Python is not available (see also #4225).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boegel I updated my local version of Tk to use zlib 1.2.11.
I missed the 2.7.13 version because I didn't check the develop branch earlier. Sorry for that.
For easyconfigs that need other updated easyconfigs, how should I pull-request them? All needed files in one pull request?
Travis test report: 8/8 runs failed - see https://travis-ci.org/hpcugent/easybuild-easyconfigs/builds/226280310 Only showing partial log for 1st failed test suite run 4411.1;
|
@henkela You should drop the easyconfig for Python 2.7.12 if it's no longer relevant (see http://easybuild.readthedocs.io/en/latest/Integration_with_GitHub.html#deleting-easyconfig-files-or-patches), and update the PR title. To answer your question w.r.t. dependencies: if the total amount of easyconfigs is reasonable (say, < 10), it's OK to pack them all in a single pull request, especially if they're trivial version/toolchain updates since those are easy to review for us via One thing you should do is clean up the contributed easyconfig file, by removing the auto-added comments like |
Test report by @boegel |
Test report by @boegel |
lgtm |
Going in, thanks @henkela! |
(created using
eb --new-pr
)