GPAW version 1.3.0 with PAW atomic setups #5613
Conversation
|
Test report by @schiotz |
| +if 'blas' in libraries: | ||
| + libraries.remove('blas') | ||
| +if 'lapack' in libraries: | ||
| + libraries.remove('lapack') |
There was a problem hiding this comment.
there are other libraries than can already have been detected by get_system_config, e.g. f77blas, cblas, atlas (see test report). imho, it would be better to completely ignore the previous contents of libraries
| +libraries += ['readline'] | ||
| + | ||
| +# Use BLAS and LAPACK libraries from EasyBuild | ||
| +path = os.getenv('EBROOTOPENBLAS') |
There was a problem hiding this comment.
wouldn't it be better to make this script more generic w.r.t. toolchains? e.g.
libraries = [libfile[3:-2] for libfile in os.getenv('LAPACK_STATIC_LIBS').split(',')]
mpi_libraries = [libfile[3:-2] for libfile in os.getenv('SCALAPACK_STATIC_LIBS').split(',')]should work for any toolchain.
There was a problem hiding this comment.
+1 for making this more generic if possible
|
Test report by @migueldiascosta |
|
superseded by PR #6514 |
(created using
eb --new-pr)