Skip to content

Commit

Permalink
don't try to exclude skipped steps from total step count (just always…
Browse files Browse the repository at this point in the history
… update easyconfig progress bar), self.skip_step only really works after check_readiness_step has been run...
  • Loading branch information
boegel committed Oct 28, 2021
1 parent 8d1d8c6 commit fe9b9b1
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions easybuild/framework/easyblock.py
Original file line number Diff line number Diff line change
Expand Up @@ -3745,8 +3745,7 @@ def run_all_steps(self, run_test_cases):
# figure out how many steps will actually be run (not be skipped)
step_cnt = 0
for (step_name, _, _, skippable) in steps:
if not self.skip_step(step_name, skippable):
step_cnt += 1
step_cnt += 1
if self.cfg['stop'] == step_name:
break

Expand Down Expand Up @@ -3793,7 +3792,7 @@ def run_all_steps(self, run_test_cases):
elif self.logdebug or build_option('trace'):
print_msg("... (took < 1 sec)", log=self.log, silent=self.silent)

update_progress_bar(PROGRESS_BAR_EASYCONFIG)
update_progress_bar(PROGRESS_BAR_EASYCONFIG)

except StopException:
pass
Expand Down

0 comments on commit fe9b9b1

Please sign in to comment.