fix issue in bootstrap script with vsc-base being picked up from the OS #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wpoely86: please review? |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2837/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
👍 |
|
Thanks for the review @wpoely86! |
boegel
added a commit
that referenced
this pull request
Mar 7, 2016
fix issue in bootstrap script with vsc-base being picked up from the OS
|
Thanks for the fix @boegel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for an issue that only occurs if
vsc-baseis already installed system-wide (reported by @ehiggs).This replicates the part of easybuilders/easybuild-easyblocks#813 where
vsc-baseis installed again, in stage 1 of the bootstrap procedure (where we're installing EasyBuild in a temporary location, so not usingebyet).