add support for 'devel' log level #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
11 tasks
|
@wpoely86 please review? The 2nd step here would be to actually switch to using |
wpoely86
reviewed
Nov 7, 2016
| @@ -58,6 +59,10 @@ | |||
| DRY_RUN_MODULES_INSTALL_DIR = None | |||
|
|
|||
|
|
|||
| DEVEL_LOG_LEVEL = logging.DEBUG - 1 | |||
There was a problem hiding this comment.
no, it's a lower logging level; log.devel messages should not be included when using --debug, but log.debug messages should be included when using --devel (see also the added test)
There was a problem hiding this comment.
@wpoely86 so, is this good to go?
wpoely86
approved these changes
Nov 7, 2016
|
Thanks for the review @wpoely86! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, debug logs are very verbose, with lots of information being logged that is only really useful when developing EasyBuild features.
One particular example in the logging by the toolchain mechanism.
With this
devellog level in place, we could avoid including stuff like this indebuglogs, while avoiding having to remove thelog.debugstatements entirely.Once a review of all current
log.debugstatements is done and the relevant ones are 'downgraded' tolog.devel, we can consider make debug logging the default in EasyBuild v3.0.0 (potentially combined with zipping logs by default).cc @wpoely86, @ocaisa