Support for lowercase module naming scheme #3199
Conversation
easybuild/tools/module_naming_scheme/lowercase_module_naming_scheme.py
Outdated
Show resolved
Hide resolved
easybuild/tools/module_naming_scheme/lowercase_module_naming_scheme.py
Outdated
Show resolved
Hide resolved
lucamar
changed the title
|
@lucamar we probably need a test for this new MNS, see |
| from easybuild.tools.module_naming_scheme.utilities import det_full_ec_version | ||
|
|
||
|
|
||
| class LowercaseModuleNamingScheme(ModuleNamingScheme): |
There was a problem hiding this comment.
@lucamar Wouldn't it make sense to derive this from EasyBuildMNS, and rename it to LowercaseEasyBuildMNS?
There was a problem hiding this comment.
@boegel Sure, I can change it to a subclass of EasyBuildMNS and the rename the file as lowercase_mns.py: I think that initially we just copied the structure of categorized_mns.py as a template
| :param ec: dict-like object with easyconfig parameter values (e.g. 'name', 'version', etc.) | ||
| :return: string with full module name <name>/<installversion>, e.g.: 'gzip/1.5-goolf-1.4.10' | ||
| """ | ||
| return os.path.join(ec['name'], det_full_ec_version(ec)).lower() |
There was a problem hiding this comment.
This could be simplified to
return super(EB_LowercaseEasyBuildMNS, self).det_full_module_name().lower()There was a problem hiding this comment.
Thanks for the hint, however if I change it as you suggested, I keep getting the NameError below:
NameError: global name 'EB_LowercaseEasyBuildMNS' is not defined
Maybe I'm missing something trivial...
|
@lucamar the test should probably be on the same level as |
…into lowercase_module_naming_scheme
As discussed already by @gppezzi with @boegel, I'm submitting a pull request to support the lowercase module naming scheme in EasyBuild (release 4).