Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Perl as a potential case for versionsuffix mapping when using --try-update-deps #3350

Merged

Conversation

ocaisa
Copy link
Member

@ocaisa ocaisa commented May 26, 2020

Fixes #3349

@ocaisa
Copy link
Member Author

ocaisa commented May 26, 2020

This allows the dependency to be resolved in the particular use case:

eb --try-toolchain=intel,2019b --robot --experimental --try-update-deps BioPerl-1.7.2-intel-2018b-Perl-5.28.0.eb -D

but an alternative match actually exists, XML-LibXML-2.0201-GCCcore-8.3.0.eb, this isn't chosen because we changed convention and decided to drop the Perl suffix recently. We can't predict a change in convention, howver you could build in logic to account for this...but we would first need to agree on exactly what our conventions are :P

@ocaisa
Copy link
Member Author

ocaisa commented May 26, 2020

If this were me I would recommend doing a dry run with the --copy-ec parameter:

eb --try-toolchain=intel,2019b --robot --experimental --try-update-deps --copy-ec -D BioPerl-1.7.2-intel-2018b-Perl-5.28.0.eb my_tweaked_ecs

then going in and fiddling with the dep to use the latest version and then building things.

@ocaisa
Copy link
Member Author

ocaisa commented May 26, 2020

I guess I could add a feature to provide a warning if there is a case where a version exists without a versionsuffix and is newer (would be particularly useful for Python versionsuffixes I suspect).

I'll open an issue for this rather than consider it here, it's non-trivial.

@boegel boegel added the bug fix label Jun 10, 2020
@boegel boegel added this to the next release (4.2.2?) milestone Jun 10, 2020
@boegel boegel merged commit 5f6bfc5 into easybuilders:develop Jun 30, 2020
@boegel boegel changed the title Include Perl as a potential case for versionsuffix mapping Include Perl as a potential case for versionsuffix mapping when using --try-update-deps Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--test-update-deps + --try-toolchain fails with Perl versionsuffix
2 participants