Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ignoring versionsuffix in --try-update-deps #3353

Merged
merged 13 commits into from
Jun 30, 2020

Conversation

ocaisa
Copy link
Member

@ocaisa ocaisa commented May 26, 2020

Fixes #3351

@easybuilders easybuilders deleted a comment from boegelbot May 27, 2020
@ocaisa ocaisa requested a review from boegel May 27, 2020 10:08
@ocaisa
Copy link
Member Author

ocaisa commented May 27, 2020

Example case, first without option:

alanc@~/EasyBuild_Git/easybuild-framework(allow_ignoring_versionsuffix)$ eb --try-toolchain=intel,2019b --robot --experimental --try-update-deps -D  --disable-minimal-toolchains BioPerl-1.7.2-intel-2018b-Perl-5.28.0.eb
== temporary log file in case of crash /tmp/eb-lS5RRf/easybuild-FgltLZ.log

WARNING: There may be newer version(s) of dep 'XML-LibXML' available with a different versionsuffix to '-Perl-5.30.0': ['/home/alanc/EasyBuild_Git/easybuild-easyconfigs/easybuild/easyconfigs/x/XML-LibXML/XML-LibXML-2.0201-GCCcore-8.3.0.eb']

Dry run: printing build status of easyconfigs and dependencies
 ...
 * [ ] /home/alanc/EasyBuild_Git/easybuild-easyconfigs/easybuild/easyconfigs/p/Perl/Perl-5.30.0-GCCcore-8.3.0.eb (module: Compiler/GCCcore/8.3.0 | Perl/5.30.0)
 * [ ] /home/alanc/EasyBuild_Git/easybuild-easyconfigs/easybuild/easyconfigs/l/libxml2/libxml2-2.9.9-GCCcore-8.3.0.eb (module: Compiler/GCCcore/8.3.0 | libxml2/2.9.9)
 * [ ] /tmp/eb-lS5RRf/tweaked_dep_easyconfigs/XML-LibXML-2.0132-GCCcore-8.3.0-Perl-5.30.0.eb (module: Compiler/GCCcore/8.3.0 | XML-LibXML/2.0132-Perl-5.30.0)
 * [ ] /home/alanc/EasyBuild_Git/easybuild-easyconfigs/easybuild/easyconfigs/i/iimpi/iimpi-2019b.eb (module: Core | iimpi/2019b)
 * [ ] /home/alanc/EasyBuild_Git/easybuild-easyconfigs/easybuild/easyconfigs/i/imkl/imkl-2019.5.281-iimpi-2019b.eb (module: MPI/intel/2019.5.281/impi/2018.5.288 | imkl/2019.5.281)
 * [ ] /home/alanc/EasyBuild_Git/easybuild-easyconfigs/easybuild/easyconfigs/i/intel/intel-2019b.eb (module: Core | intel/2019b)
 * [ ] /tmp/eb-lS5RRf/tweaked_easyconfigs/BioPerl-1.7.2-intel-2019b-Perl-5.30.0.eb (module: MPI/intel/2019.5.281/impi/2018.5.288 | BioPerl/1.7.2-Perl-5.30.0)
== Temporary log file(s) /tmp/eb-lS5RRf/easybuild-FgltLZ.log* have been removed.
== Temporary directory /tmp/eb-lS5RRf has been removed.

and now with

alanc@~/EasyBuild_Git/easybuild-framework(allow_ignoring_versionsuffix)$ eb --try-toolchain=intel,2019b --robot --experimental --try-update-deps -D --try-ignore-versionsuffix --disable-minimal-toolchains BioPerl-1.7.2-intel-2018b-Perl-5.28.0.eb
== temporary log file in case of crash /tmp/eb-jRDsvF/easybuild-BX6_7n.log
Dry run: printing build status of easyconfigs and dependencies
 ...
 * [ ] /home/alanc/EasyBuild_Git/easybuild-easyconfigs/easybuild/easyconfigs/p/Perl/Perl-5.30.0-GCCcore-8.3.0.eb (module: Compiler/GCCcore/8.3.0 | Perl/5.30.0)
 * [ ] /home/alanc/EasyBuild_Git/easybuild-easyconfigs/easybuild/easyconfigs/l/libxml2/libxml2-2.9.9-GCCcore-8.3.0.eb (module: Compiler/GCCcore/8.3.0 | libxml2/2.9.9)
 * [ ] /home/alanc/EasyBuild_Git/easybuild-easyconfigs/easybuild/easyconfigs/x/XML-LibXML/XML-LibXML-2.0201-GCCcore-8.3.0.eb (module: Compiler/GCCcore/8.3.0 | XML-LibXML/2.0201)
 * [ ] /home/alanc/EasyBuild_Git/easybuild-easyconfigs/easybuild/easyconfigs/i/iimpi/iimpi-2019b.eb (module: Core | iimpi/2019b)
 * [ ] /home/alanc/EasyBuild_Git/easybuild-easyconfigs/easybuild/easyconfigs/i/imkl/imkl-2019.5.281-iimpi-2019b.eb (module: MPI/intel/2019.5.281/impi/2018.5.288 | imkl/2019.5.281)
 * [ ] /home/alanc/EasyBuild_Git/easybuild-easyconfigs/easybuild/easyconfigs/i/intel/intel-2019b.eb (module: Core | intel/2019b)
 * [ ] /tmp/eb-jRDsvF/tweaked_easyconfigs/BioPerl-1.7.2-intel-2019b-Perl-5.30.0.eb (module: MPI/intel/2019.5.281/impi/2018.5.288 | BioPerl/1.7.2-Perl-5.30.0)
== Temporary log file(s) /tmp/eb-jRDsvF/easybuild-BX6_7n.log* have been removed.
== Temporary directory /tmp/eb-jRDsvF has been removed.

@boegel boegel added the bug fix label Jun 10, 2020
@boegel boegel added this to the next release (4.2.2?) milestone Jun 10, 2020
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit a4fcae2 into easybuilders:develop Jun 30, 2020
@boegel boegel changed the title Allow ignoring versionsuffix in try-update-deps Allow ignoring versionsuffix in --try-update-deps Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn of additional potential matches when using try-update-deps
2 participants