Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't inject -Wl,-rpath options when '-x c++-header' compiler option is used #3424

Merged
merged 2 commits into from
Aug 31, 2020
Merged

don't inject -Wl,-rpath options when '-x c++-header' compiler option is used #3424

merged 2 commits into from
Aug 31, 2020

Conversation

boegel
Copy link
Member

@boegel boegel commented Aug 28, 2020

fixes #3371

@boegel boegel added the bug fix label Aug 28, 2020
@boegel boegel added this to the next release (4.3.0) milestone Aug 28, 2020
@boegel boegel mentioned this pull request Aug 28, 2020
Closed
bartoldeman
bartoldeman approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bartoldeman bartoldeman merged commit 10824e3 into easybuilders:develop Aug 31, 2020
@boegel boegel deleted the rpath_args_script_fixes branch August 31, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartoldeman bartoldeman bartoldeman approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

RPath compiler wrapper breaking precompiled header builds
2 participants
@boegel @bartoldeman