Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix combination of --copy-ec and --from-pr #3482

Merged
merged 52 commits into from
Nov 30, 2020

Conversation

boegel
Copy link
Member

@boegel boegel commented Oct 25, 2020

This continues from the work done by @ocaisa in #3473, and fixes the combination of --copy-ec and --from-pr.

The scope of this PR is pretty big, and I feel it should be split up into several PRs, so I made this a draft PR for now.

High level overview of additional changes:

fixes #3178

@boegel boegel added the bug fix label Oct 25, 2020
@boegel boegel added this to the 4.x milestone Oct 25, 2020
@boegel boegel modified the milestones: 4.x, 4.3.2 Oct 25, 2020
@boegel boegel changed the title fix combination of --copy-eb and --from-pr fix combination of --copy-ec and --from-pr Nov 25, 2020
@easybuilders easybuilders deleted a comment from boegelbot Nov 26, 2020
@boegel boegel marked this pull request as ready for review November 26, 2020 13:22
@boegel
Copy link
Member Author

boegel commented Nov 26, 2020

@ocaisa This should be good to go now, can you give it another look?

Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a typo, will take a deeper look while you fix that

easybuild/framework/easyconfig/tools.py Outdated Show resolved Hide resolved
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, one minor request

test/framework/options.py Show resolved Hide resolved
@migueldiascosta
Copy link
Member

also lgtm, fwiw (and more importantly, it works! :) )

@ocaisa ocaisa merged commit 0fb8d5e into easybuilders:develop Nov 30, 2020
@boegel boegel deleted the copy-ec-from-pr branch November 30, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eb --copy-ec does not work with --from-pr yet
3 participants