Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix regression in apply_regex_substitutions: also accept list of paths to patch #3507

Merged
merged 2 commits into from
Nov 28, 2020
Merged

fix regression in apply_regex_substitutions: also accept list of paths to patch #3507

merged 2 commits into from
Nov 28, 2020

Conversation

boegel
Copy link
Member

@boegel boegel commented Nov 28, 2020

fixes #3493

@boegel boegel added the bug fix label Nov 28, 2020
@boegel boegel added this to the 4.3.2 (next release) milestone Nov 28, 2020
Micket
Micket approved these changes Nov 28, 2020
View reviewed changes
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket merged commit 529a8b5 into easybuilders:develop Nov 28, 2020
@boegel boegel deleted the apply_regex_substitutions_path_list branch November 28, 2020 16:28
@boegel boegel mentioned this pull request Nov 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Micket Micket Micket approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.3.2
Development

Successfully merging this pull request may close these issues.

crash in apply_regex_substitutions in EasyBuild v4.3.1 when passing list of paths to patch
2 participants
@boegel @Micket