Catch problems early on if --github-user is not specified for --new-pr & co #3644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
requested changes
Apr 10, 2021
…figs_pr_common helper function + require that target_account is not None in setup_repo_from and push_branch_to_github
boegel
changed the title
boegel
changed the title
added 2 commits
April 10, 2021 12:17
make sure that --github-org or --github-user is specified in _easyconfigs_pr_common helper function + require that target_account is not None in setup_repo_from and push_branch_to_github
boegel
approved these changes
Apr 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3642 but probably could error earlier for the case of
--new-prrather than waste time cloning the repo