-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable code linting check for all supported Python versions #3725
Conversation
seems to work, tests fail because we're now catching errors:
|
@boegel This looks ok to me, and the caught error might need to be fixed .... |
@JensTimmerman could you do "eb --sync-pr-with-develop 3725 --pr-target-repo easybuild-framework" on this one to make sure it's up to date. |
@akesandgren that didn't seem to work for me, I just merged develop into this branch, if that also works for you? |
It did exactly what it needed to do, make sure that it applies on top of current develop HEAD and re-kick the test suite. You could also add a small fix for the line redefined problem it detects, not sure what @boegel would accept here but I think |
py3 functions will always fail in py2, so ignore for linting for now. c
.github/workflows/linting.yml
Outdated
@@ -18,4 +22,4 @@ jobs: | |||
|
|||
- name: Run flake8 to verify PEP8-compliance of Python code | |||
run: | | |||
flake8 | |||
flake8 --exclude ./easybuild/tools/py2vs3/py3.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally this only get's skipped for python2, but I couldn't quickly find a good filter for this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in a2ec58b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks a lot @JensTimmerman! |
enable code linting check for all supported Python versions
run linting tests for all supported python versions