Check for recursive symlinks by default before copying a folder #3784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids endless loops and creating infinite length paths when `symlinks=True` is NOT also passed to copy_dir
Flamefire
force-pushed
the
avoid_recursive_copies
branch
from
167330f
to
9fd7157
Compare
|
Going in, thanks @Flamefire! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids endless loops and creating infinite length paths when
symlinks=Trueis NOT also passed to copy_dirThis turned up when naively testing easybuilders/easybuild-easyconfigs#13469 without the
keepsymlinkssetting which ended up "hanging" in the install step until I eventually found out about the recursive symlink manually.This PR should avoid such cases.
Downside: Traversing the whole source tree before a copy. Shouldn't be too bad as those are usually on fast, local disks and as the results of the traversal might even be cached it could make the actual copy happening later a bit faster reducing the impact of the check.
It will also follow symlinks to absolute paths and check there. Not fully sure about that but as the copy done afterwards does the same I don't think this is an additional problem.