Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check_async_cmd function to facilitate checking on asynchronously running commands #3865

Merged
merged 8 commits into from
Oct 22, 2021

Conversation

boegel
Copy link
Member

@boegel boegel commented Oct 21, 2021

This will come in handy for #3667, fleshed this out in a separate PR to avoid making #3667 too big...

@boegel boegel added this to the 4.5.0 (next release) milestone Oct 21, 2021
akesandgren
akesandgren previously approved these changes Oct 21, 2021
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

easybuild/tools/run.py Show resolved Hide resolved
easybuild/tools/run.py Outdated Show resolved Hide resolved
easybuild/tools/run.py Show resolved Hide resolved
easybuild/tools/run.py Outdated Show resolved Hide resolved
akesandgren
akesandgren previously approved these changes Oct 22, 2021
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren akesandgren merged commit 31d0c59 into easybuilders:develop Oct 22, 2021
@boegel boegel deleted the check_async_cmd branch October 22, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants