Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix library paths to add to $LDFLAGS for intel-compilers toolchain component #3866

Merged
merged 1 commit into from
Oct 25, 2021
Merged

fix library paths to add to $LDFLAGS for intel-compilers toolchain component #3866

merged 1 commit into from
Oct 25, 2021

Conversation

akesandgren
Copy link
Contributor

No description provided.

@akesandgren akesandgren added this to the 4.5.0 (next release) milestone Oct 21, 2021
@akesandgren akesandgren mentioned this pull request Oct 21, 2021
Merged
@boegel boegel changed the title Fix IntelCompilers libpaths to actually point to the compiler libs fix library paths to add to $LDFLAGS for intel-compilers toolchain component Oct 22, 2021
@branfosj branfosj mentioned this pull request Oct 23, 2021
Merged
@bartoldeman bartoldeman merged commit 16737b4 into easybuilders:develop Oct 25, 2021
@boegel
Copy link
Member

boegel commented Oct 25, 2021

After looking into this a bit more, the fix seems fully correct to me.
Since the paths that are currently specified don't even exist at all, it's fine to remove those, and only add the necessary path (<installdir>/compiler/<version>/linux/compiler/lib/intel64).

I've tested all easyconfigs that use a toolchain with intel-compilers as compiler component on top of this, all work fine (as expected).

@akesandgren akesandgren deleted the fix_intelcompiler_libpath_setting branch October 25, 2021 13:51
@boegel boegel mentioned this pull request Oct 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

@bartoldeman bartoldeman bartoldeman approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@akesandgren @boegel @bartoldeman