remove '--depth 1' from git clone when 'commit' is specified in git_config

[branfosj]

(created using eb --new-pr)

fixes #3870

The --depth 1 breaks any git download where we want to switch to a commit, as that commit will not be in the git history that we've downloaded.

edit (by @boegel): for reference: this problem was introduced in commit 956fa9c which is a part of #3795 that was merged for EasyBuild v4.4.2

[ocaisa]

Rather than remove this optimisation, can't we just add an or not commit to the condition?

[branfosj]

Rather than remove this optimisation, can't we just add an or not commit to the condition?

Yes, that makes sense. Though it has to be and not commit, which I've done in 0aae4d7.

[ocaisa]

LGTM, going in! Thanks @branfosj

[boegel]

@branfosj How difficult would it be to add a test that triggers the bug being fixed here?

[boegel]

@branfosj We're actually testing this already, but the bug was left unnoticed because we're using the latest available commit, so using --depth 1 was not a problem... Test fixed in #3872