Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate use of (actual) patch files that don't have a filename ending with .patch #3920

Merged
merged 6 commits into from
Jan 10, 2022
Merged

deprecate use of (actual) patch files that don't have a filename ending with .patch #3920

merged 6 commits into from
Jan 10, 2022

Conversation

smoors
Copy link
Contributor

@smoors smoors commented Dec 28, 2021

fixes #3688

@smoors smoors added the change label Dec 28, 2021
@smoors smoors added this to the 4.x milestone Dec 28, 2021
@smoors smoors mentioned this pull request Dec 28, 2021
Closed
@easybuilders easybuilders deleted a comment from boegelbot Dec 28, 2021
@easybuilders easybuilders deleted a comment from boegelbot Dec 28, 2021
@easybuilders easybuilders deleted a comment from boegelbot Dec 29, 2021
@boegel boegel changed the title add deprecation warning for patches without .patch suffix deprecate use of patch files that don't have a filename ending with .patch Jan 4, 2022
boegel
boegel requested changes Jan 4, 2022
View reviewed changes
easybuild/tools/filetools.py Outdated Show resolved Hide resolved
@boegel boegel modified the milestones: 4.x, next release (4.5.2?) Jan 10, 2022
@ocaisa
Copy link
Member

ocaisa commented Jan 10, 2022

@boegel This looks ok to me, I leave it to you to merge since you already reviewed it

@boegel boegel merged commit b955d76 into develop Jan 10, 2022
@boegel boegel deleted the patch_suffix branch January 10, 2022 14:02
@boegel boegel changed the title deprecate use of patch files that don't have a filename ending with .patch deprecate use of (actual) patch files that don't have a filename ending with .patch Jan 23, 2022
@boegel boegel mentioned this pull request Jan 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

@ocaisa ocaisa ocaisa approved these changes

Assignees
No one assigned
Labels
change
Projects
None yet
Milestone
4.5.2
Development

Successfully merging this pull request may close these issues.

surprising behavior with patch files that don't have .patch extension
3 participants
@smoors @ocaisa @boegel