fix build options that should have empty list as default value #4108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alphabetical order for the lists
branfosj
previously approved these changes
Nov 23, 2022
|
I fixed the conflict caused by #3749 and the reordering of the lists. |
branfosj
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For build options like
from_prwe assume throughout the code that they have an empty list as default value, see for example:easybuild-framework/easybuild/framework/easyconfig/tools.py
Line 343 in 95bae20
There are situations where that's currently not the case though, primarily when EasyBuild is being used as a library (cfr. this tutorial section).
That's fixed by the changes being made here, by implementing special treatment for build options that should have a unique empty list as default value.