Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add run_shell_cmd hook #4323

Merged
merged 11 commits into from
Aug 15, 2023
Merged

add run_shell_cmd hook #4323

merged 11 commits into from
Aug 15, 2023

Conversation

boegel
Copy link
Member

@boegel boegel commented Aug 11, 2023

  • 😎 : run_shell_cmd hook that triggers before/after running a shell command (works for both run_cmd and run_cmd_qa);
  • ⚠️ some exceptions necessary for commands run in systemtools + set_tmpdir, because they are run before EasyBuild configuration is properly set up (so build_option doesn't work yet);
  • 🔥 pre_run_shell_cmd_hook can modify the command before running it;
  • 📖 additional context is available:
    • working directory;
    • output + exit code for post_run_shell_cmd_hook;
    • discriminate between interactive and non-interactive commands;
  • ✅ tests have been added/extended to ensure implementation works as designed;

@boegel boegel added this to the next release (4.8.1?) milestone Aug 11, 2023
@easybuilders easybuilders deleted a comment from boegelbot Aug 12, 2023
Copy link
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfgrimm
Copy link
Member

jfgrimm commented Aug 15, 2023

Going in, thanks @boegel!

@jfgrimm jfgrimm merged commit ac91659 into easybuilders:develop Aug 15, 2023
34 checks passed
@boegel boegel deleted the run_cmd_hook branch August 15, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants