Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend test that checks build environment to recent foss/2023a toolchain #4391

Merged
merged 11 commits into from
Dec 8, 2023

Conversation

smoors
Copy link
Contributor

@smoors smoors commented Nov 27, 2023

(created using eb --new-pr)

let's see if it catches the bug that should be fixed in #4379

@easybuilders easybuilders deleted a comment from boegelbot Dec 6, 2023
@easybuilders easybuilders deleted a comment from boegelbot Dec 6, 2023
@easybuilders easybuilders deleted a comment from boegelbot Dec 6, 2023
@boegel boegel added the tests label Dec 6, 2023
@boegel boegel added this to the next release (4.9.0?) milestone Dec 6, 2023
@boegel
Copy link
Member

boegel commented Dec 6, 2023

@smoors Is this still WIP?

@boegel boegel changed the title extend test to recent toolchain extend test that checks build environment to recent foss/2023a toolchain Dec 6, 2023
@smoors smoors marked this pull request as draft December 6, 2023 08:40
@smoors
Copy link
Contributor Author

smoors commented Dec 6, 2023

@smoors Is this still WIP?

yes, still some modules missing. converted to draft for now

@boegelbot
Copy link

@smoors: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-framework/actions/runs/7121224277
Output from first failing test suite run:

FAIL: test_old_new_iccifort (test.framework.toolchain.ToolchainTest)
Test whether preparing for old/new Intel compilers works correctly.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/runner/01f9b50f3bdbeb3fd362e140b65d2263bd03a587/lib/python3.6/site-packages/easybuild/base/testing.py", line 97, in assertEqual
    super(TestCase, self).assertEqual(a, b)
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/unittest/case.py", line 829, in assertEqual
    assertion_func(first, second, msg=msg)
AssertionError: 'libflexiblas.so,libgfortran.so' != 'libflexiblas.so,libgfortran.so,libpthread.so'
- libflexiblas.so,libgfortran.so
+ libflexiblas.so,libgfortran.so,libpthread.so
?                               ++++++++++++++


During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/tmp/runner/01f9b50f3bdbeb3fd362e140b65d2263bd03a587/lib/python3.6/site-packages/test/framework/toolchain.py", line 1888, in test_old_new_iccifort
    blas_mt_shared_libs_fosscuda.replace('openblas', 'flexiblas'))
  File "/tmp/runner/01f9b50f3bdbeb3fd362e140b65d2263bd03a587/lib/python3.6/site-packages/easybuild/base/testing.py", line 119, in assertEqual
    raise AssertionError("%s:\nDIFF%s:\n%s" % (msg, limit, ''.join(diff[:self.ASSERT_MAX_DIFF])))
AssertionError: 'libflexiblas.so,libgfortran.so' != 'libflexiblas.so,libgfortran.so,libpthread.so'
- libflexiblas.so,libgfortran.so
+ libflexiblas.so,libgfortran.so,libpthread.so
?                               ++++++++++++++
:
DIFF:
- libflexiblas.so,libgfortran.so+ libflexiblas.so,libgfortran.so,libpthread.so

----------------------------------------------------------------------
Ran 855 tests in 604.363s

FAILED (failures=1)
ERROR: Not all tests were successful.

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@boegelbot
Copy link

@smoors: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-framework/actions/runs/7121224273
Output from first failing test suite run:

FAIL: test_old_new_iccifort (test.framework.toolchain.ToolchainTest)
Test whether preparing for old/new Intel compilers works correctly.
----------------------------------------------------------------------
Log available at /tmp/eb-Agdbde/eb-tHfcxn/easybuild-tests-bhacGc.log
Traceback (most recent call last):
  File "/tmp/01f9b50f3bdbeb3fd362e140b65d2263bd03a587/lib/python2.7/site-packages/test/framework/toolchain.py", line 1888, in test_old_new_iccifort
    blas_mt_shared_libs_fosscuda.replace('openblas', 'flexiblas'))
  File "/tmp/01f9b50f3bdbeb3fd362e140b65d2263bd03a587/lib/python2.7/site-packages/easybuild/base/testing.py", line 119, in assertEqual
    raise AssertionError("%s:\nDIFF%s:\n%s" % (msg, limit, ''.join(diff[:self.ASSERT_MAX_DIFF])))
AssertionError: 'libflexiblas.so,libgfortran.so' != 'libflexiblas.so,libgfortran.so,libpthread.so':
DIFF:
- libflexiblas.so,libgfortran.so+ libflexiblas.so,libgfortran.so,libpthread.so

----------------------------------------------------------------------
Ran 855 tests in 1235.678s

FAILED (failures=1)
ERROR: Not all tests were successful.

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@easybuilders easybuilders deleted a comment from boegelbot Dec 7, 2023
@smoors
Copy link
Contributor Author

smoors commented Dec 7, 2023

the new tests correctly fail: missing pthreads
let's merge this into #4379

@boegel boegel merged commit 046fe23 into easybuilders:develop Dec 8, 2023
27 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants