Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dict.items() instead of repeatedly getting the value #4533

Merged
merged 1 commit into from
May 22, 2024

Conversation

Flamefire
Copy link
Contributor

Simple refactoring making the code faster and shorter

Targetting 5.0x because Python 2 creates a copy not a view

@smoors smoors added the EasyBuild-5.0 EasyBuild 5.0 label May 20, 2024
@boegel boegel added this to the 5.0 milestone May 21, 2024
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit d391629 into easybuilders:5.0.x May 22, 2024
35 checks passed
@Flamefire Flamefire deleted the use-dict-items branch May 22, 2024 20:44
@boegel boegel changed the title Use dict.items() instead of repeatedly getting the value Use dict.items() instead of repeatedly getting the value Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants