Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing dots from backup message produced by --inject-checksums #4632

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

Flamefire
Copy link
Contributor

The dots usually indicate some upcoming process or shortened information. Neither is true at this point: The backup file has been saved. Removing the dots makes it also easier to C&P the resulting name as the selection will no longer automatically contain the dots.

This has bothered me many times now as I do not want the backup file in the first place and a double click on the output selected the dots so I couldn't C&P the filename to the rm command

The dots usually indicate some upcoming process or shortened information.
Neither is true at this point: The backup file *has* been saved.
Removing the dots makes it also easier to C&P the resulting name as the
selection will no longer automatically contain the dots.
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added the change label Sep 12, 2024
@boegel boegel added this to the 4.9.3 milestone Sep 12, 2024
@boegel boegel changed the title Remove trailing dots from backup message. Remove trailing dots from backup message produced by --inject-checksums Sep 12, 2024
@boegel boegel merged commit 3475f9d into easybuilders:develop Sep 12, 2024
37 checks passed
@Flamefire Flamefire deleted the dots-removal branch September 12, 2024 16:17
boegel added a commit to migueldiascosta/easybuild-framework that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants