feat(SearchBar): add shortcut (cmd/ctrl + K) support #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksarlou
force-pushed
the
feature-add-shortcut-support
branch
from
0aa4cfb
to
c66851d
Compare
|
Very nice! What's the process to get this merged? |
|
Thanks for your work and sorry for the late response. I got very little spare time to maintain this project recently. But I'll try reviewing this PR later this week. |
|
Hello! Thanks for your comments! Should I make any more changes? |
|
Hi @ksarlou Thanks for your contribution! And sorry again for being late. And I just made some refining based on your commit:
|
weareoutman
approved these changes
Dec 4, 2021
|
Hi guys, this is just released in v0.21.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue: #110 (comment)