chore: improve translations for multi-locale #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Well done! I think it would be better if we provide a new option to keep backward compatibilities. E.g., a new option of |
|
I made the changes that you suggest, is it OK ? 🙂 |
weareoutman
reviewed
Apr 6, 2021
| | searchResultLimits | number | `8` | Limit the search results. | | ||
| | searchResultContextMaxLength | number | `50` | Set the max length of characters of each search result to show. | | ||
| | translations | TranslationMap | - | Set translations of this plugin, see [docs below](#translations). | | ||
| | i18n | TranslationLocaleMap | - | Allow to translate the plugin for more than one locale, see [docs below](#translations). | |
There was a problem hiding this comment.
I'm not familiar with i18n in Docusaurus right now, but I think we should follow the official i18n guide of Docusaurus, it seems that it supports i18n of plugins which is defined by files in specific path.
By the way, I have a limited time to maintain this project and to learn new features from Docusaurus, so it may take days to review a PR.
|
Hi we just supported docusaurus i18n system in #182 , so we're going to close this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
First, thanks a lot for this incredible plugin for Docusaurus ! 👌 I used it at work to search in my docs in two languages.
Nevertheless, it was not possible to localized this plugin in more than one locale, so this is the goal of this PR. Feel free to make me remarks. ;-)