fix(eo-iframe): do not render iframe if no src

easyops-cn · Sep 5, 2024 · ac1c3d0 · ac1c3d0
1 parent 846ca27
commit ac1c3d0
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/bricks/basic/src/iframe/index.spec.tsx b/bricks/basic/src/iframe/index.spec.tsx
@@ -40,4 +40,23 @@ describe("eo-iframe", () => {
       document.body.removeChild(element);
     });
   });
+
+  test("set src later", async () => {
+    const element = document.createElement("eo-iframe") as Iframe;
+
+    act(() => {
+      document.body.appendChild(element);
+    });
+    expect(element.shadowRoot?.querySelectorAll("iframe").length).toBe(0);
+
+    await act(async () => {
+      element.src = "http://localhost/iframe";
+      await (global as any).flushPromises();
+    });
+    expect(element.shadowRoot?.querySelectorAll("iframe").length).toBe(1);
+
+    act(() => {
+      document.body.removeChild(element);
+    });
+  });
 });
diff --git a/bricks/basic/src/iframe/index.tsx b/bricks/basic/src/iframe/index.tsx
@@ -116,5 +116,5 @@ export function LegacyIframeComponent(
     };
   }, [onLoad]);
 
-  return <iframe src={src} style={iframeStyle} ref={iframeRef} />;
+  return src ? <iframe src={src} style={iframeStyle} ref={iframeRef} /> : null;
 }