Port from xml-rs to quick-xml

[jcgruenhage]

Follow-up from #78. Things that happened since:

• rebased this on the current changes on master
• dropped the quick-xml impl into where the xml-rs one used to be, instead of offering quick-xml as a feature
• fixed up the issue with pending collections
• fixed a whole lot of clippy issues while I was at it

Thanks to @pr2502 for doing the heavy lifting here, most stuff was already in pretty good shape so I mostly just moved stuff around and did a few little touch-ups here and there.

[RickyDaMa]

Hi there!

While not a maintainer of this repo, I am a keen Rustacean with an interest in the original issue, so I hope you don't mind my feedback.

Thanks for continuing on this work!

[jcgruenhage]

Thanks for your feedback, @RickyDaMa. I've applied most of your suggestions, they do improve the code quite a bit. I'll be honest: I haven't completely read the code that I committed, just the bits I needed to touch to apply the feedback from over at #78 😅, as well as a bit required for #52 later on, although I haven't started implementation on that one yet, as I'd want this here and #85 to be merged first.

[RickyDaMa]

No problem, I will admit I originally did the review thinking this was a repository I had some association with, but glad I helped nonetheless 😅 Hope this can get merged!

[ebarnard]

@RickyDaMa Thanks for doing the review for me 😁! I'll try and take a look at it later today.

[ebarnard]

It's looking pretty good @jcgruenhage, just a few changes. I've only reviewed the first commit, please could you drop the clippy changes from this PR for the time being and put them in another once this is merged.

[jcgruenhage]

Thanks for the extensive review @ebarnard, I'll try to get the requested changes in today :)

[jcgruenhage]

I've addressed all of the feedback except for the Reader::check_end_names thing so far, because that'll be a slightly bigger change. I hope I'll get to that later as well though.

[jcgruenhage]

Okay, @ebarnard, your feedback should now be fully addressed, let me know if there is anything else you'd want changed here.

[pr2502]

hi @jcgruenhage thank you for finishing this! i'm happy you decided to tag me as a co-author, but may i ask you to replace my old tag with max <[email protected]>. thanks a lot ^^

[jcgruenhage]

Sure thing!

[ebarnard]

Two more small questions and then we're good to go. Thank you so much @jcgruenhage for taking time to work on this.

[jcgruenhage]

@ebarnard I think this is ready now. One question: What's going to be the next released version? Asking because of the deprecation warning on XmlWriteOptions::indent_string

[ebarnard]

Think it should be 1.4

[jcgruenhage]

Then the deprecation is already good as it is. With your approval on it now, do you want to merge it?

[lucasfernog]

@ebarnard do you have an idea when this could be released?

[ebarnard]

v1.4 has now been released.