First attempt at implementing a DNSMADEEASY provider using their API #254
Conversation
MatthewSteeples
force-pushed
the
master
branch
2 times, most recently
from
94c0d01
to
3d5c620
Compare
|
This would be great! I was going to start writing a powershell script to interface with DNSMadeEasy to insert the TXT records, but if this provider is built, all the better! Let me know if you need help testing! |
|
Used this properly ourselves today, and successfully renewed our certificates automagically
|
|
Rebased off master, I think this is probably ready to go in now @ebekker |
| } | ||
| } | ||
|
|
||
| private string getRecordId(DnsChallenge dnsChallenge, DomainDetails domainDetails, string records) |
There was a problem hiding this comment.
Correct the casing of the method as per default conventions. There are several other locations throughout down below as well.
|
|
||
| namespace ACMESharp.ACME.Providers | ||
| { | ||
| /// <summary> |
There was a problem hiding this comment.
Update the XML Comments and attribute description with specifics for the DNSME provider.
|
@MatthewSteeples , thank you for the contribution! I've requested a few changes in the code to improve the code quality. |
|
@MatthewSteeples, are you able to test out this code against the DME SANDBOX environment (e.g. API endpoint That is, if you use the sandbox, will it actually make changes that can be queried by the Let's Encrypt servers. In my testing, any record that I put into a SANDBOX account do not resolve. So if I create a TXT resource record, it can't be queried by the LE servers. Is this the same thing you are finding? |
|
@ebekker Sorry for the delay. I'll get the code updated this week Regarding sandbox, any changes you make to DME Sandbox will not be returned to public DNS queries so LE will not be able to query it. You can test that the updates are being made, but only with a production DME account will LE be able to action the changes |
MatthewSteeples
force-pushed
the
master
branch
from
7349a88
to
8764cad
Compare
|
Pushed an update to resolve the merge conflicts, update method names to fit in with existing convention and updated XML docs |
|
Hi folks, where are we at with this? I have a need to use DNS Made Easy as a provider and was about to roll my own when I stumbled upon this. |
|
The docs have also been updated with this, so hopefully everything works for those with DNS-M-E, give it a try and let us know. |
|
Forgive me for my limited knowledge, but I cannot seem to get this working with staging. If I specify my HandlerParamaters as @{ApiKey = "xxxx"; SecretKey = "yyyy"; Staging = "true"} I get an InvalidCastException. When I omit the Staging option, my PS console crashes without displaying an error. I can't seem to figure out the correct syntax for the Staging boolean - what am I missing? |
|
@MatthewSteeples is going to have to step in here to help, I have no access to DME. |
|
Which version of Windows / Powershell are you running? |
|
Server 2016, Powershell 5.1.14393.1770 |
|
@engageant I can't get the same error here locally. Do you have the right kind of DNSME account for API access (it's not on the basic tier). If you do, could you do a Fiddler trace and send me (privately if you want) a Fiddler trace of the requests to/from DNSME? |
|
Perhaps my understanding of the 'staging' parameter is incorrect - is that
not for testing in DME's sandbox?
…On Tue, Oct 31, 2017 at 4:48 PM Matthew Steeples ***@***.***> wrote:
@engageant <https://github.com/engageant> I can't get the same error here
locally. Do you have the right kind of DNSME account for API access (it's
not on the basic tier). If you do, could you do a Fiddler trace and send me
(privately if you want) a Fiddler trace of the requests to/from DNSME?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#254 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADSI6gnuXFH_gQmXMefKzim2aZiPkSBdks5sx4ehgaJpZM4NwgwA>
.
|
|
@engageant Correct. It's more for testing the functionality of the code rather than the certificates that you want to create. Any changes made in DNSME's sandbox will not be visible to LE's servers, which means that they won't be able to use those results to produce certificates |
|
@MatthewSteeples I'm using a sandbox account for my testing here. The domain I'm requesting a cert for is set up in the sandbox account. Am I formatting the staging parameter correctly? |
|
@MatthewSteeples was saying that changes made in STAGING will not be visible to LE, so you cannot make a request for a cert from LE if you're using only DME STAGING. DME STAGING is just so you can test interaction with DME's APIs only. |
|
Right - understood. My test was failing well before any cert was requested.
…On Sat, Nov 4, 2017 at 7:15 AM Eugene Bekker ***@***.***> wrote:
@MatthewSteeples <https://github.com/matthewsteeples> was saying that
changes made in STAGING will *not* be visible to LE, so you *cannot* make
a request for a cert from LE if you're using only DME STAGING.
DME STAGING is just so you can test interaction with DME's APIs only.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#254 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADSI6u0t2e_5S4x7xTmYKR8RN8RBhrOCks5szEc3gaJpZM4NwgwA>
.
|
|
I've just noticed in your variable that Staging may need to be a boolean rather than a string. Can you try $True instead of true in quotes? Doesn't explain which it's crashing if you omit the variable though |
Comments welcome