Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library_preparation_protocol.library_construction_method.ontology_label differs markedly from text #335

Closed
NoopDog opened this issue May 19, 2021 · 9 comments
Assignees
Labels
dataset All dataset tickets should have this label, only one ticket per dataset operations This issue is an operational task

Comments

@NoopDog
Copy link
Collaborator

NoopDog commented May 19, 2021

We might want to check this one as the ontology_text says 10X 5' v2 sequencing but the ontology_label says 10X 3' v2 sequencing. One of them may be a typo.

Project Detail Page project_id library_preparation_protocol_id ontology_id ontology_label text
https://data.humancellatlas.org/explore/projects/9d97f01f-9313-416e-9b07-560f048b2350 9d97f01f-9313-416e-9b07-560f048b2350 71f59197-d9fe-4ced-b2c7-43cbfecc5eb4 EFO:0009899 10X 3' v2 sequencing 10X 5' v2 sequencing

For context see
https://docs.google.com/spreadsheets/d/1Wk7SGxEz00AkNokYv3YlFHJVF9U6THKcrvgHARsnau8/edit#gid=0

and

HumanCellAtlas/dcp2#13

@lauraclarke lauraclarke added the operations This issue is an operational task label May 19, 2021
@rays22 rays22 self-assigned this May 24, 2021
@clairerye
Copy link
Contributor

This was wrangled by Parisa, I will ask her to clarify which is correct.

@rays22 rays22 added the dataset All dataset tickets should have this label, only one ticket per dataset label May 28, 2021
@rays22
Copy link
Contributor

rays22 commented May 28, 2021

I can not fix this issue until Parisa confirms what the correct library preparation technology versions were used for each of the two library preparation protocols in the project.

library_preparation_protocol.uuid   library_preparation_protocol.protocol_core.protocol_id  library_preparation_protocol.protocol_core.protocol_name    library_preparation_protocol.protocol_core.protocol_description    library_preparation_protocol.library_construction_method.text   library_preparation_protocol.library_construction_method.ontology    library_preparation_protocol.library_construction_method.ontology_label library_preparation_protocol.library_construction_kit.retail_name
71f59197-d9fe-4ced-b2c7-43cbfecc5eb4    LP_a30170acbd2e4c58c9e3ce4445691dfe Genomics_prep_10x_5'_v2 The single-cell capturing and downstream library constructions were performed using the Chromium Single Cell 5′ library or 3' v2 library preparation kit according to the manufacturer’s protocol (10x Genomics).    10X  5' v2 sequencing   EFO:0009899 10X 3' v2 sequencing    Chromium Single Cell 5′ v2 library preparation kit
cded2c1e-c49b-4e2c-9b32-6c14553a5f0b    LP_a30170acbd2e4c58c9e3ce4445691dfe.1   Genomics_prep_10x_3'_v2 The single-cell capturing and downstream library constructions were performed using the Chromium Single Cell 5′ library or 3' v2 library preparation kit according to the manufacturer’s protocol (10x Genomics).    10X 3' v2 sequencing    EFO:0009900 10X 5' v2 sequencing    Chromium Single Cell 3′ v2 library preparation kit

@rays22 rays22 added the externally blocked Issue blocked by something outside DCP label May 28, 2021
@rays22
Copy link
Contributor

rays22 commented Jun 4, 2021

I am still blocked from progressing on this update until I get the necessary information from Parisa to my query email of 28/5/2021.

@willrockout
Copy link
Collaborator

It is 5' and 3' it just seems that the ontologies were accidentally switched. Follow the name and other information for which is which

@rays22 rays22 removed the externally blocked Issue blocked by something outside DCP label Jun 11, 2021
@rays22
Copy link
Contributor

rays22 commented Jun 11, 2021

Thank you @willrockout .

  • I have swapped the ontology terms and IDs so that they match the library_preparation_protocol.protocol_core.protocol_name
Genomics_prep_10x_5'_v2	-->	10x 5' v2 (EFO:0009900)
Genomics_prep_10x_3'_v2	-->	10x 3' v2 (EFO:0009899)
  • I am trying to export the updated project to the DCP now.

@rays22 rays22 added internally blocked Issue blocked by something within DCP and removed internally blocked Issue blocked by something within DCP labels Jun 11, 2021
@rays22
Copy link
Contributor

rays22 commented Jun 11, 2021

The update should fix the ontology issue in release 7.

@NoopDog
Copy link
Collaborator Author

NoopDog commented Jun 11, 2021 via email

@rays22
Copy link
Contributor

rays22 commented Jun 11, 2021

Release 7 is the target.

@NoopDog
Copy link
Collaborator Author

NoopDog commented Jun 11, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataset All dataset tickets should have this label, only one ticket per dataset operations This issue is an operational task
Projects
None yet
Development

No branches or pull requests

6 participants