Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload form in the submission view #102

Merged
merged 14 commits into from
Jul 21, 2021
Merged

Upload form in the submission view #102

merged 14 commits into from
Jul 21, 2021

Conversation

aaclan-ebi
Copy link
Contributor

@aaclan-ebi aaclan-ebi commented Jul 6, 2021 •
edited by amnonkhen
Loading

@aaclan-ebi aaclan-ebi self-assigned this Jul 7, 2021
@aaclan-ebi aaclan-ebi changed the title Feature/spreadsheet updates Upload form in the submission view Jul 7, 2021
@aaclan-ebi
Copy link
Contributor Author

Screenshot 2021-07-07 at 13 00 24

@aaclan-ebi aaclan-ebi requested a review from a team July 7, 2021 12:01
@aaclan-ebi aaclan-ebi marked this pull request as ready for review July 7, 2021 12:01
amnonkhen
amnonkhen requested changes Jul 7, 2021
View reviewed changes
client/src/app/app.module.ts Outdated Show resolved Hide resolved
amnonkhen
amnonkhen requested changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@amnonkhen amnonkhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we need any UI tests here?

@aaclan-ebi aaclan-ebi requested a review from a team July 7, 2021 19:34
ke4
ke4 previously approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@ke4 ke4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , although I agree with @amnonkhen regarding to the missing tests. 😜

@aaclan-ebi
Copy link
Contributor Author

aaclan-ebi commented Jul 9, 2021 •
edited
Loading

@ke4 i already added tests for upload component, is there anything else you'd like to cover?

@aaclan-ebi aaclan-ebi mentioned this pull request Jul 9, 2021
Closed
@aaclan-ebi aaclan-ebi changed the base branch from master to dev July 19, 2021 13:48
@aaclan-ebi aaclan-ebi dismissed ke4’s stale review July 19, 2021 13:48

The base branch was changed.

ke4
ke4 previously approved these changes Jul 19, 2021
View reviewed changes
ke4
ke4 previously approved these changes Jul 19, 2021
View reviewed changes
ke4
ke4 previously approved these changes Jul 20, 2021
View reviewed changes
ke4
ke4 previously approved these changes Jul 21, 2021
View reviewed changes
@ke4 ke4 merged commit 5e52dff into dev Jul 21, 2021
@aaclan-ebi aaclan-ebi deleted the feature/spreadsheet-updates branch February 17, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobwindsor jacobwindsor jacobwindsor approved these changes

@ke4 ke4 ke4 approved these changes

@amnonkhen amnonkhen amnonkhen approved these changes

Assignees

@aaclan-ebi aaclan-ebi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating metadata JSON via spreadsheet
4 participants
@aaclan-ebi @amnonkhen @ke4 @jacobwindsor