Improve error message of missing or invalid params #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebkalderon
force-pushed
the
expand-invalid-params-case
branch
2 times, most recently
from
1e6761d
to
29ba44d
Compare
These changes let us identify when a required `params` field has been omitted and correctly report it as a "invalid params" error instead of a "parse error" and also provide detailed output from `serde_json::Error` in the `message` field, if there is any. We also take the opportunity to eliminate most of the noisy duplicate logging calls in `handle_request()`. We will provide this info to the user at the transport layer instead, starting in the next commit.
ebkalderon
force-pushed
the
expand-invalid-params-case
branch
from
29ba44d
to
9387d47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
Fixed
paramsfield (for messages that require it) as "invalid params" instead of "parse error."