Handle incoming zero-length messages #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebkalderon
force-pushed
the
handle-zero-length-messages
branch
2 times, most recently
from
e88fd62
to
d90e9b4
Compare
ebkalderon
changed the title
ebkalderon
force-pushed
the
handle-zero-length-messages
branch
from
d90e9b4
to
250ff9b
Compare
While these messages are peculiar, they seem to be allowed by the spec. The current code fails to parse such messages with the following error: ``` failed to decode message: unable to parse JSON body: EOF while parsing a value at line 1 column 0 ``` This is ultimately emitted by `serde_json::from_str` which is unable to deserialize the zero-length string as JSON. To resolve this, we add a special case to the decoder which detects zero-length messages and ignores them, skipping forward to decode the next message in the stream.
ebkalderon
force-pushed
the
handle-zero-length-messages
branch
from
250ff9b
to
1f5e598
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
Content-Lengthof zero.While these messages are peculiar, they seem to be allowed by the LSP spec. The current code fails to parse such messages with the following error:
This is ultimately emitted by
serde_json::from_strwhich is unable to deserialize the zero-length string as JSON. To resolve this, we add a special case to the decoder which detects zero-length messages and ignores them, skipping forward to decode the next message in the stream.Fixes #239.