Eliminate looping, message reparsing in codec with take_until #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes `LanguageServerCodec` to recover from parse failures more efficiently. Using nom's SIMD-accelerated `take_until()` combinator, we can skip forward in the byte stream much more efficiently and without any message reparsing nor looping necessary.
This commit adds a helper function for encoding test LSP messages and expands codec test coverage, checking for more parse errors.
ebkalderon
force-pushed
the
eliminate-message-reparsing-in-codec
branch
from
0233a9c
to
c537596
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
encode_message()helper function to reduce boilerplate in codec tests.Changes
take_until().