Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet connect 2): @taquito/wallet-connect-2 package + support in the Taquito test dapp #2059

Open
wants to merge 57 commits into
base: master
Choose a base branch
from

Conversation

roxaneletourneau
Copy link
Collaborator

@roxaneletourneau roxaneletourneau commented Oct 24, 2022

Closes #2145
Closes #2146

Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

  • Your code builds cleanly without any errors or warnings
  • You have added unit tests
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

@netlify
Copy link

netlify bot commented Oct 24, 2022

Deploy Preview for taquito-test-dapp ready!

Name Link
🔨 Latest commit f9eb1d8
🔍 Latest deploy log https://app.netlify.com/sites/taquito-test-dapp/deploys/639d084bcd7c1d0008f7a3a2
😎 Deploy Preview https://deploy-preview-2059--taquito-test-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Oct 24, 2022

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/

@github-actions
Copy link

github-actions bot commented Oct 24, 2022

A new deploy preview is available on Netlify at https://cb361e9--tezostaquito.netlify.app

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022

Codecov Report

Base: 81.95% // Head: 81.95% // No change to project coverage 👍

Coverage data is based on head (9b70c9b) compared to base (6be3114).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2059   +/-   ##
=======================================
  Coverage   81.95%   81.95%           
=======================================
  Files         215      215           
  Lines       12085    12085           
  Branches     2736     2736           
=======================================
  Hits         9904     9904           
  Misses       2159     2159           
  Partials       22       22           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@roxaneletourneau roxaneletourneau changed the title feat(wallet connect 2): first commit feat(wallet connect 2): @taquito/wallet-connect-2 package + support in the Taquito test dapp Nov 23, 2022
@roxaneletourneau roxaneletourneau marked this pull request as ready for review December 17, 2022 00:20
@BearCooder
Copy link

Hi @dsawali do you know who is reviewing this PR?

@dsawali
Copy link
Contributor

dsawali commented Jul 6, 2023

Hello @BearCooder, this PR is actually a work in progress. Myself and other Taquito team members are going to be reviewing it, but as it stands right now this is more of a PoC. There needs to be a lot more polish and updating for it to be ready for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support wallet connect 2 in the Taquito test dapp Implement a wallet provider for wallet connect 2
5 participants