-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle taquito beacon wallet #2744
Conversation
✅ Deploy Preview for taquito-test-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/. Published packages:
|
A new deploy preview is available on Netlify at https://f41231d--tezostaquito.netlify.app |
@hui-an-yang have we tested whether the beacon wallet bundle is importable and usable? |
I've tested the bundle described here, and successfully been able to do what I need to do from a JS environment (Blazor WASM, which has only JS interop). importing the bundles in index.html:
In a beaconWrapper.js file that I call via interop:
Is there a reason this PR was closed? It would be very useful to have this in the master branch so that I can have Visual Studio build the bundles as part of my build process, rather than having to manually build and import the taquito_beacon_wallet.js file to my project. I've also added a comment to #2694 describing what I think the problem might have been for the OP. |
Hey @oldominion, it was closed back then because the bundle was tested in a browser import directly but wasn't working as intended. But I'm glad the contents of this bundle worked for your problem. May I ask how you are building Taquito locally for your Blazor project? If this does get merged to master, we will also upload the bundle as a .zip file on a release. |
I just built with..
..then imported the taquito_beacon_wallet.js file via <script> tag as described earlier. |
@oldominion perfect, that's exactly how we'd intended this bundle to be used. We'll test it a bit more and then release it sometime soon. When it does reach master and gets an official release, you can expect to directly be able to grab the |
…ito-beacon-wallet
…dle-taquito-beacon-wallet
…dle-taquito-beacon-wallet
…dle-taquito-beacon-wallet
…dlabs/taquito into bundle-taquito-beacon-wallet
Deploying with Cloudflare Pages
|
Adding taquito-beacon-wallet bundling to ci
Thank you for your contribution to Taquito.
Before submitting this PR, please make sure:
In this PR, please also make sure:
closes #TICKETNUMBER
in the description box (when applicable)Release Note Draft Snippet
If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.