-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve story design #2590
Merged
manuelmeister
merged 5 commits into
ecamp:devel
from
manuelmeister:feature/story-design
Apr 26, 2022
Merged
Improve story design #2590
manuelmeister
merged 5 commits into
ecamp:devel
from
manuelmeister:feature/story-design
Apr 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelmeister
force-pushed
the
feature/story-design
branch
from
April 14, 2022 16:47
b4f1b9f
to
b8c2aa5
Compare
BacLuc
reviewed
Apr 17, 2022
pmattmann
requested changes
Apr 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gefällt mir im Gross und Ganzen gut!
Für Approve:
- Übersetzungen aufräumen
Idee / Optional:
- Clips find ich zu klein - siehe Kommentar im Code
manuelmeister
force-pushed
the
feature/story-design
branch
from
April 18, 2022 14:15
b8c2aa5
to
eeb0ef2
Compare
pmattmann
approved these changes
Apr 18, 2022
usu
requested changes
Apr 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visually looks good to me. A few minor comments as below.
usu
approved these changes
Apr 26, 2022
Don't show an accordion if there is only one period
manuelmeister
force-pushed
the
feature/story-design
branch
from
April 26, 2022 21:20
f9cd021
to
b9064dc
Compare
manuelmeister
removed
the
deploy!
Creates a feature branch deployment for this PR
label
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extracted the visual improvements made of the story context in #2576
https://pr2590.ecamp3.ch