Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve story design #2590

Merged
merged 5 commits into from
Apr 26, 2022
Merged

Conversation

manuelmeister
Copy link
Member

@manuelmeister manuelmeister commented Apr 14, 2022

I extracted the visual improvements made of the story context in #2576

https://pr2590.ecamp3.ch

@manuelmeister manuelmeister added the deploy! Creates a feature branch deployment for this PR label Apr 14, 2022
Copy link
Member

@pmattmann pmattmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gefällt mir im Gross und Ganzen gut!

Für Approve:

  • Übersetzungen aufräumen

Idee / Optional:

  • Clips find ich zu klein - siehe Kommentar im Code

frontend/src/components/story/CategoryChip.vue Outdated Show resolved Hide resolved
frontend/src/locales/en.json Outdated Show resolved Hide resolved
frontend/src/locales/en.json Outdated Show resolved Hide resolved
Copy link
Member

@usu usu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually looks good to me. A few minor comments as below.

frontend/src/scss/global.scss Outdated Show resolved Hide resolved
frontend/src/scss/global.scss Outdated Show resolved Hide resolved
frontend/src/scss/global.scss Outdated Show resolved Hide resolved
frontend/src/locales/en-CH-scout.json Outdated Show resolved Hide resolved
frontend/src/locales/en.json Outdated Show resolved Hide resolved
@manuelmeister manuelmeister requested a review from usu April 24, 2022 12:07
@manuelmeister manuelmeister removed the deploy! Creates a feature branch deployment for this PR label Apr 26, 2022
@manuelmeister manuelmeister merged commit aa479e0 into ecamp:devel Apr 26, 2022
@manuelmeister manuelmeister deleted the feature/story-design branch April 26, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants