Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible copyright/license violations. #22

Open
RobertZenz opened this issue Oct 23, 2017 · 4 comments
Open

Possible copyright/license violations. #22

RobertZenz opened this issue Oct 23, 2017 · 4 comments

Comments

@RobertZenz
Copy link
Collaborator

Introduction

Since we've had time to review most of the code we've come to the conclusion that this plugin is possibly violating the copyright/license of two other projects:

There might be more, but these are the two that stood out to us, I'll explain both in detail.

jd-eclipse

jd-eclipse is (even few a lot smaller) quite similar to structure and naming and there is a very high likely hood that ECD was originally based upon this code. I could not find irrefutable evidence that this is the case, but it sure smells like it. I've tried contacting the original author of jd-eclipse to request their opinion, but so far I've not heard back from them.

jd-eclipse is licensed under GPLv3, which, if this is the case, e relicense of ECD would be required.

freeplugins

To be honest, I could not find a lot of information on these, so I'm a little bit lost. Some of the code in the source.attach plugin is copied verbatim from these projects.

freeplugins might be licensed under Apache 2.0, the project itself does not carry information, but the Marketplace entry does.

Request for help

I request the help from anyone who has the time and will to have a look at this, please review the code and if you find something that might come from a different project, notify us in this issue. We should resolve these situations as soon as possible.

Additionally, if somebody has the possibility to contact the authors of jd-eclipse and freeplugins directly, please do so and notify them of this, their input is required here.

@leibnitz27
Copy link

You should certainly provide attribution / include component licenses / backlinks in documentation. For example, CFR (I'm the author, so I can at least speak for that one :) ) is provided under the MIT license, which at least asks for attribution.

@RobertZenz
Copy link
Collaborator Author

@leibnitz27 Very good call, we should definitely also mention the embedded and used decompilers and their licenses, even when they are "just" binaries and not source code.

@RobertZenz
Copy link
Collaborator Author

I've already opened jd-eclipse#24 in the [jd-eclipse]((https://github.com/java-decompiler/jd-eclipse) project, but anyone who has the possibility to contact the author directly, please do so.

@pbi-qfs
Copy link
Collaborator

pbi-qfs commented Jun 18, 2018

It looks like this is the author-clone of the google repo of free-plugins: https://github.com/tha2015/free-plugins
The license is: Apache 2 (https://github.com/tha2015/free-plugins/blob/master/org.freejava.javasourceattacher.feature/feature.xml)

pbi-qfs added a commit that referenced this issue Jun 18, 2018
Since it is based on jd-eclipse, there is no choice...
@RobertZenz RobertZenz modified the milestones: 3.1, 3.2 Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants