Fix gcc build warning #101
Conversation
kumajaya
force-pushed
the
fix/gcc-warning
branch
from
bd51801
to
375a49f
Compare
kumajaya
force-pushed
the
fix/gcc-warning
branch
from
375a49f
to
65b73bc
Compare
Move the switch case into an own method to make the code much more readable
kumajaya
force-pushed
the
fix/gcc-warning
branch
from
65b73bc
to
ea1ccaa
Compare
| default: | ||
| DEVLOG_ERROR("Unknown escape symbol %c encountered", inputString[i + 1]); | ||
| if (getSpecialSymbol(inputString[i + 1], specialSymbol) != -1) { | ||
| unescapedString += specialSymbol; // append escaped char |
There was a problem hiding this comment.
As mentioned before, shouldn't we abort with an error here? @azoitl
Now we are just not adding the invalid escaped symbol, thereby silently ignoring an error, right?
There was a problem hiding this comment.
True I missed that. However, giving it a second thought I'm not perfectly sure what should happen here. I had a look in IEC 61131-3 and there nothing is stated about invalid $ escapings. Does anyone know what other languages are doing. Should we just ignore the $ then. I think this is what happens in C or?
There was a problem hiding this comment.
The compiler gives you an error what I have seen on StackOverflow
There was a problem hiding this comment.
The previous logic possibly add uninitialized specialSymbol char that trigger compiler warning. I'm also not sure what should happen here.
There was a problem hiding this comment.
Don't get me wrong, it is an improvement. I am. Just not sure if we should create a valid string in such a case
There was a problem hiding this comment.
@kumajaya first of all thx for your patience with us. With your work you are definitely improving 4diac FORTE. But as you are poking on a rather important component and as you are changing it, we think it would be good that we get it right this time.
There was a problem hiding this comment.
@azoitl No problem, sir! I found this great project and started loving it from the beginning because it seemed to suit my needs. Just a little help from my side, I always take compiler warnings seriously and try to understand why they occur but of course I always need good guidance from people who understand more here.
There was a problem hiding this comment.
@kumajaya it's good you fix compiler warnings, it is important and I fixed a bunch myself, but not always high on our priorities ;)
No description provided.