First version of a CVS reader block #223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinMelikMerkumians
requested changes
Sep 5, 2024
| void GEN_CSV_READER::openCSVFile() { | ||
| QO() = false_BOOL; | ||
| if(!mCSVFile.is_open()) { | ||
| mCSVFile.open(FILE_NAME().getStorage().c_str()); |
There was a problem hiding this comment.
you are calling c_str() several times. I would suggest to store the result of the first call and use it later, as FILE_NAME will probably not modified in this function anymore
| std::size_t oldPos = 0; | ||
|
|
||
| for(std::size_t i = 0; i < getNumRD(); i++) { | ||
| std::size_t newPos = line.find(';', oldPos); |
There was a problem hiding this comment.
seeing this, you implicitly assume a German-language CSV file, correct?
English-language (and several others) CSVs use the comma ',' as the separator.
In the current version the use of the CSV Reader is limited to German-language (or others using the semicolon as separator) CSVs. I would suggest to extract the separator to an additional input for the FB, enhancing usability of the FB
|
GOOD ! as said, i would like to make a INI-File Reader-Writer Block. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.