Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ASSEMBLE_XX_FROM_BOOLS_fct files under utils #230

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

MoritzO02
Copy link

Created a directory under utils named "assembling" and added four functions. In total eight files.

for issue eclipse-4diac/4diac-ide#222

@MoritzO02 MoritzO02 changed the title Add ASSEMBE_XX_FROM_BOOLS_fct files under utils Add ASSEMBLE_XX_FROM_BOOLS_fct files under utils Sep 17, 2024
Copy link
Contributor

@azoitl azoitl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix the copyright headers. In that form they are not acceptable.

@MoritzO02
Copy link
Author

Can you please fix the copyright headers. In that form they are not acceptable.

Have the headers like this with one *?
image

So it is also wrong in this file?
image

@azoitl
Copy link
Contributor

azoitl commented Sep 21, 2024

@MoritzO02 both I fine. I just had a second look at your PR. The reason I missunderstood is that you made a PR with 6 commits. When I get PRs like that I assume that each commit is in itself self contained and should be preserved. Therefore I review each commit individually. This makes reviewing commits easier for me. So for the future I kindly ask you to support me making reviews for your PRs easier. You can do this by presquashing your commits on your side and rebasing the result on top of develop. This allows you also to give the final commit message and I don't have to generate one when squashing the commits on my side here in github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants