Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation of the JDBC connection property validation #1838

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Documentation of the JDBC connection property validation #1838

merged 1 commit into from
Aug 5, 2024

Conversation

speckyspooky
Copy link
Contributor

No description provided.

@speckyspooky speckyspooky added this to the 4.17 milestone Aug 5, 2024
@speckyspooky speckyspooky self-assigned this Aug 5, 2024
@speckyspooky
Copy link
Contributor Author

The documentation is part of the change for #1832

@speckyspooky speckyspooky merged commit 1e8ba02 into eclipse-birt:master Aug 5, 2024
3 checks passed
hvbtup
hvbtup reviewed Aug 7, 2024
View reviewed changes
Copy link
Contributor

@hvbtup hvbtup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the time ATM, but a brief look shows that the documentation contains some typical mistakes of Germans speaking English, for example "must not" probably means "doesn't have to" here, etc..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvbtup hvbtup hvbtup left review comments

Assignees

@speckyspooky speckyspooky

Labels
Documentation
Projects
None yet
Milestone
4.17
Development

Successfully merging this pull request may close these issues.
2 participants
@speckyspooky @hvbtup