Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test org.eclipse.birt.axis.utility.UTF8Encoder is used and is correct #1860

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

merks
Copy link
Contributor

@merks merks commented Aug 18, 2024

  • Include org.eclipse.birt.axis.overlay in the org.eclipse.birt.engine.runtime feature.
  • Test both runtimes that they use the overlay correctly.
  • Reconcile the difference between the features org.eclipse.birt.osgi.runtime and org.eclipse.birt.engine.runtime.
    • Remove org.eclipse.birt.resources because it only provides cheatsheet content for in the IDE.
    • Add org.eclipse.birt.chart.device.pdf and org.eclipse.birt.report.engine.emitter.prototype.excel.

- Include org.eclipse.birt.axis.overlay in the
org.eclipse.birt.engine.runtime feature.
- Test both runtimes that they use the overlay correctly.
- Reconcile the difference between the features
org.eclipse.birt.osgi.runtime and org.eclipse.birt.engine.runtime.
  - Remove org.eclipse.birt.resources because it only provides
cheatsheet content for in the IDE.
  - Add org.eclipse.birt.chart.device.pdf and
org.eclipse.birt.report.engine.emitter.prototype.excel.
@merks
Copy link
Contributor Author

merks commented Aug 18, 2024

@speckyspooky

It's bothered me for a while that I didn't know what org.eclipse.birt.axis.overlay actually does. It was introduced without any tests. So I investigated and indeed the Axis encoding of surrogate pairs is broken without the fix provided by org.eclipse.birt.axis.utility.UTF8Encoder so I added a test for that. It also bothered me that the org.eclipse.birt.axis.overlay bundle (a fragment with org.apache.axis as its host) is not included in the runtime, so I added the same encoding test for both runtimes and modified the feature to include the fragment so that the tests pass; this inclusion transitively includes the host bundle as well then.

At this point there was almost no difference between the org.eclipse.birt.engine.runtime feature and the org.eclipse.birt.osgi.runtime feature so I removed org.eclipse.birt.resources (a UI thing) and add the missing plugins such that the two features are now identical.

I think at this point I can simplify the OSGi runtime product to use the org.eclipse.birt.osgi.runtime, removing the org.eclipse.birt.chart.osgi.runtime feature because all its includes are also in the org.eclipse.birt.osgi.runtime feature already.

I'll do that as a separate step...

@merks merks self-assigned this Aug 18, 2024
@merks merks merged commit 82bc5c6 into eclipse-birt:master Aug 18, 2024
3 checks passed
@merks merks deleted the pr-axis-overlay branch August 18, 2024 11:30
@speckyspooky speckyspooky added this to the 4.17 milestone Aug 18, 2024
@speckyspooky
Copy link
Contributor

@merks
Good to know that there are such kind of problems will fixed through such workaround.
But if it works then all is fine.

@speckyspooky speckyspooky added the Dependencies Pull requests that update a dependency file label Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants