-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions for Windows shows some flakiness #222
Comments
Sometimes even 5 seconds isn't enough - here is a bad run:
And here is a good run:
In the first run it is >5 seconds to do what took ~1.5 seconds in the first run. This is very reminiscent of why we have huge multipliers on timeouts when running DSF-GDB tests on test machine. I think we'll do the same here. |
jonahgraham
added a commit
to jonahgraham/cdt-gdb-adapter
that referenced
this issue
Sep 27, 2022
…oud#222 The mocha timeout code was random throughout all the different tests, instead move it to the common util file. This means that we can make all the timeouts the same.
jonahgraham
added a commit
to jonahgraham/cdt-gdb-adapter
that referenced
this issue
Sep 27, 2022
…oud#222 The mocha timeout code was random throughout all the different tests, instead move it to the common util file. This means that we can make all the timeouts the same.
jonahgraham
added a commit
to jonahgraham/cdt-gdb-adapter
that referenced
this issue
Sep 27, 2022
…oud#222 The mocha timeout code was random throughout all the different tests, instead move it to the common util file. This means that we can make all the timeouts the same.
jonahgraham
added a commit
that referenced
this issue
Sep 27, 2022
The mocha timeout code was random throughout all the different tests, instead move it to the common util file. This means that we can make all the timeouts the same.
jonahgraham
added a commit
to thamho0902/cdt-gdb-adapter
that referenced
this issue
Sep 30, 2022
See issue eclipse-cdt-cloud#222 and the fix there for more details as to why.
jonahgraham
added a commit
to jonahgraham/cdt-gdb-adapter
that referenced
this issue
Jan 24, 2023
Most of the timeouts for tests are the mocha timeouts, but DebugClient has its own timeout values. This change synchronizes those values. This increased timeout is specifically needed for the attachRemote test which takes more than 5 seconds to do the initial connection on the GitHub actions build regularly. This is a follow up to commit 3708cea part of eclipse-cdt-cloud#222
jonahgraham
added a commit
to jonahgraham/cdt-gdb-adapter
that referenced
this issue
Jan 25, 2023
Most of the timeouts for tests are the mocha timeouts, but DebugClient has its own timeout values. This change synchronizes those values. This increased timeout is specifically needed for the attachRemote test which takes more than 5 seconds to do the initial connection on the GitHub actions build regularly. This is a follow up to commit 3708cea part of eclipse-cdt-cloud#222
jonahgraham
added a commit
that referenced
this issue
Jan 26, 2023
Most of the timeouts for tests are the mocha timeouts, but DebugClient has its own timeout values. This change synchronizes those values. This increased timeout is specifically needed for the attachRemote test which takes more than 5 seconds to do the initial connection on the GitHub actions build regularly. This is a follow up to commit 3708cea part of #222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am seeing some flaky tests on GHA when running on Windows.
My initial guess is this is too short a timeout on Windows as numerous tests take ~2 seconds on Windows.
The text was updated successfully, but these errors were encountered: