Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load/Save memory content #50

Closed
jreineckearm opened this issue Dec 8, 2023 · 2 comments · Fixed by #96
Closed

Load/Save memory content #50

jreineckearm opened this issue Dec 8, 2023 · 2 comments · Fixed by #96
Assignees
@martin-fleck-at

Comments

@jreineckearm
Copy link
Contributor

Description

It would be a powerful feature to save and load memory contents. This data could be stored in a variety of formats. For example Intel Hex format or plain binary.

Additional information
@planger
Copy link
Contributor

planger commented Feb 27, 2024

I'd have a few questions on this topic:

  • Should only the memory be stored that is currently visible / loaded in a memory view instance based on the start address and offset values or do we need a separate dialog asking the user for the address range?
  • When loading the memory back from a file, should it be just shown in a new memory view instance or also written back to a debug adapter (WriteMemoryRequest)?

@planger
Copy link
Contributor

planger commented Feb 27, 2024

From a discussion offline:

  • Users should be able to specify start address and size when triggering the save. The pre-filled values should correspond to what the user has specified in the memory view instance.
  • When loading back from file, the memory for the address range should be written back into the memory of the debug target.

@martin-fleck-at martin-fleck-at self-assigned this Feb 28, 2024
martin-fleck-at added a commit to eclipsesource/vscode-memory-inspector that referenced this issue Mar 1, 2024
@martin-fleck-at
Support storing and applying of memory content
61a889e 
Add commands to store and apply memory content as Intel HEX file
- Encapsulate behavior in new MemoryStorage class
- Trigger 'store' from Memory view, Variables view and command palette
- Trigger 'apply' from Memory view, Explorer view and command palette
- Use nrf-intel-hex library for read/write file licensed under BSD-3

Use quick inputs to guide user through necessary input
- Initialize as much of the input as possible through command args

Communicate with webview through messenger requests and notifications
-- Request to trigger store and apply from webview
-- Notify webview about any written memory so it can update properly

Minor improvements
- Move some common types and functionality into 'common' area
- Provide utility functions and types for debug requests
- Fix 'Enter' handling for numpad by checking key value of event

Closes eclipse-cdt-cloud#50
martin-fleck-at added a commit to eclipsesource/vscode-memory-inspector that referenced this issue Mar 7, 2024
@martin-fleck-at
Support storing and applying of memory content
74525c8 
Add commands to store and apply memory content as Intel HEX file
- Encapsulate behavior in new MemoryStorage class
- Trigger 'store' from Memory view, Variables view and command palette
- Trigger 'apply' from Memory view, Explorer view and command palette
- Use nrf-intel-hex library for read/write file licensed under BSD-3

Use quick inputs to guide user through necessary input
- Initialize as much of the input as possible through command args

Communicate with webview through messenger requests and notifications
-- Request to trigger store and apply from webview
-- Notify webview about any written memory so it can update properly

Minor improvements
- Move some common types and functionality into 'common' area
- Avoid bleeding Debug Adapter types into webview, use messaging types
- Common style: 'getVariables' -> 'getVariablesType'
- Provide utility functions and types for debug requests
- Fix 'Enter' handling for numpad by checking key value of event

Closes eclipse-cdt-cloud#50
@martin-fleck-at martin-fleck-at mentioned this issue Mar 7, 2024
Merged
1 task
martin-fleck-at added a commit to eclipsesource/vscode-memory-inspector that referenced this issue Mar 8, 2024
@martin-fleck-at
Support storing and applying of memory content
fd3a075 
Add commands to store and apply memory content as Intel HEX file
- Encapsulate behavior in new MemoryStorage class
- Trigger 'store' from Memory view, Variables view and command palette
- Trigger 'apply' from Memory view, Explorer view and command palette
- Use nrf-intel-hex library for read/write file licensed under BSD-3

Use quick inputs to guide user through necessary input
- Initialize as much of the input as possible through command args

Communicate with webview through messenger requests and notifications
-- Request to trigger store and apply from webview
-- Notify webview about any written memory so it can update properly

Minor improvements
- Move some common types and functionality into 'common' area
- Avoid bleeding Debug Adapter types into webview, use messaging types
- Common style: 'getVariables' -> 'getVariablesType'
- Provide utility functions and types for debug requests
- Fix 'Enter' handling for numpad by checking key value of event

Closes eclipse-cdt-cloud#50
martin-fleck-at added a commit to eclipsesource/vscode-memory-inspector that referenced this issue Mar 8, 2024
@martin-fleck-at
Support storing and applying of memory content
a7c30d8 
Add commands to store and apply memory content as Intel HEX file
- Encapsulate behavior in new MemoryStorage class
- Trigger 'store' from Memory view, Variables view and command palette
- Trigger 'apply' from Memory view, Explorer view and command palette
- Use nrf-intel-hex library for read/write file licensed under BSD-3

Use quick inputs to guide user through necessary input
- Initialize as much of the input as possible through command args

Communicate with webview through messenger requests and notifications
-- Request to trigger store and apply from webview
-- Notify webview about any written memory so it can update properly

Minor improvements
- Move some common types and functionality into 'common' area
- Avoid bleeding Debug Adapter types into webview, use messaging types
- Common style: 'getVariables' -> 'getVariablesType'
- Provide utility functions and types for debug requests
- Fix 'Enter' handling for numpad by checking key value of event

Closes eclipse-cdt-cloud#50
@planger planger mentioned this issue Mar 12, 2024
Closed
5 tasks
martin-fleck-at added a commit to eclipsesource/vscode-memory-inspector that referenced this issue Mar 12, 2024
@martin-fleck-at
Support storing and applying of memory content
4e91210 
Add commands to store and apply memory content as Intel HEX file
- Encapsulate behavior in new MemoryStorage class
- Trigger 'store' from Memory view, Variables view and command palette
- Trigger 'apply' from Memory view, Explorer view and command palette
- Use nrf-intel-hex library for read/write file licensed under BSD-3

Use quick inputs to guide user through necessary input
- Initialize as much of the input as possible through command args

Communicate with webview through messenger requests and notifications
-- Request to trigger store and apply from webview
-- Notify webview about any written memory so it can update properly

Minor improvements
- Move some common types and functionality into 'common' area
- Avoid bleeding Debug Adapter types into webview, use messaging types
- Common style: 'getVariables' -> 'getVariablesType'
- Provide utility functions and types for debug requests
- Fix 'Enter' handling for numpad by checking key value of event

Closes eclipse-cdt-cloud#50
martin-fleck-at added a commit to eclipsesource/vscode-memory-inspector that referenced this issue Mar 12, 2024
@martin-fleck-at
Support storing and applying of memory content
fb67c69 
Add commands to store and apply memory content as Intel HEX file
- Encapsulate behavior in new MemoryStorage class
- Trigger 'store' from Memory view, Variables view and command palette
- Trigger 'apply' from Memory view, Explorer view and command palette
- Use nrf-intel-hex library for read/write file licensed under BSD-3

Use quick inputs to guide user through necessary input
- Initialize as much of the input as possible through command args

Communicate with webview through messenger requests and notifications
-- Request to trigger store and apply from webview
-- Notify webview about any written memory so it can update properly

Minor improvements
- Move some common types and functionality into 'common' area
- Avoid bleeding Debug Adapter types into webview, use messaging types
- Common style: 'getVariables' -> 'getVariablesType'
- Provide utility functions and types for debug requests
- Fix 'Enter' handling for numpad by checking key value of event

Closes eclipse-cdt-cloud#50
martin-fleck-at added a commit to eclipsesource/vscode-memory-inspector that referenced this issue Mar 12, 2024
@martin-fleck-at
Support storing and applying of memory content
281c374 
Add commands to store and apply memory content as Intel HEX file
- Encapsulate behavior in new MemoryStorage class
- Trigger 'store' from Memory view, Variables view and command palette
- Trigger 'apply' from Memory view, Explorer view and command palette
- Use nrf-intel-hex library for read/write file licensed under BSD-3

Use quick inputs to guide user through necessary input
- Initialize as much of the input as possible through command args

Communicate with webview through messenger requests and notifications
-- Request to trigger store and apply from webview
-- Notify webview about any written memory so it can update properly

Minor improvements
- Move some common types and functionality into 'common' area
- Avoid bleeding Debug Adapter types into webview, use messaging types
- Common style: 'getVariables' -> 'getVariablesType'
- Provide utility functions and types for debug requests
- Fix 'Enter' handling for numpad by checking key value of event

Closes eclipse-cdt-cloud#50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martin-fleck-at martin-fleck-at

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support storing and applying of memory content eclipsesource/vscode-memory-inspector
3 participants
@planger @martin-fleck-at @jreineckearm