Handle multiple experiments with the same name #240
Conversation
light2.mp4 |
This is the issue that this commit addresses |
There was a problem hiding this comment.
The change makes sense to open the panel with the correct name.
I was not able to reproduce the flickering. I guess it's timing related. I got hopeful that it would fix the flickering reported in #238, but this update doesn't address it. The Trace Compass team will investigate that issue in a separate effort.
Please update the PR for my comment in trace-utils.ts.
| ); | ||
| return; |
There was a problem hiding this comment.
If returning here no experiment is created with a subset of traces. The idea was that for a list of traces pathes in tracesArray, each trace is posted to the server. If not successful, it continues with the next trace in the array. If one or more are successfully posted, the experiment is created with these traces. Below there is a warning message created to the user of failed traces. If no trace was successfully posted the no experiment is created.
I think we should remove the return here
There was a problem hiding this comment.
My mistake - fixed!
Create panel after server instantiates the experiment and tie the panel name to experiment name Signed-off-by: Neel Gondalia <[email protected]>
ngondalia
force-pushed
the
handleExpsWithSameName
branch
from
5cbd968
to
18c5a88
Compare
It doesnt always happen - it depends on what you click after opening the second trace. For me, its always reproducible if i click the newly opened trace (2nd trace with same name) in Opened Traces view. |
I was able to reproduce it now. Thanks for the steps. |
Create panel after server instantiates the experiment and tie the panel name to the experiment name
Fixes the constant switching of tabs when multiple experiments opened with the same name
Signed-off-by: Neel Gondalia [email protected]