Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

Remove debug task in Camel stack eclipse/che#14003 #50

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

apupier
Copy link
Contributor

@apupier apupier commented Jul 24, 2019

  • cannot make it working even when attaching manually the Java debugger
    afterwise
  • Debug is available through CodeLens on the Application Java class
  • no other devfiles are providing this kind of debug task

Signed-off-by: Aurélien Pupier [email protected]

What does this PR do?

What issues does this PR fix or reference?

- cannot make it working even when attaching manually the Java debugger
afterwise
- Debug is available through CodeLens on the Application Java class
- no other devfiles are providing this kind of debug task

Signed-off-by: Aurélien Pupier <[email protected]>
@apupier
Copy link
Contributor Author

apupier commented Jul 24, 2019

please note that in constrained environments, this other PR will need to be merged too #46

@apupier apupier changed the title Remove debug task eclipse/che#14003 Remove debug task in Camel stack eclipse/che#14003 Jul 24, 2019
@l0rd
Copy link
Contributor

l0rd commented Jul 24, 2019

Same as in #46 (comment)

+1 to merge

@slemeur
Copy link

slemeur commented Jul 24, 2019

fixing eclipse-che/che#14003

Copy link
Member

@ScrewTSW ScrewTSW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same experience as @apupier
I couldn't get it running during testing.

@amisevsk
Copy link
Contributor

It's necessary to add a debug launch config to Theia for debugging to work; I'll look into it more but +1 to merge in the meantime.

@l0rd
Copy link
Contributor

l0rd commented Jul 29, 2019

@apupier please merge when you are ready

@apupier apupier merged commit 6d0f4e5 into eclipse-che:master Jul 30, 2019
@apupier apupier deleted the 14003-removeDebugTask branch July 30, 2019 09:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants